issue_comments: 434491155

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2524#issuecomment-434491155 https://api.github.com/repos/pydata/xarray/issues/2524 434491155 MDEyOklzc3VlQ29tbWVudDQzNDQ5MTE1NQ== 1217238 2018-10-30T22:20:26Z 2018-10-30T22:20:26Z MEMBER

In general, I would be OK with not testing inplace behavior carefully. We can certainly add this to specific test methods but overall I think it's better to have slightly less test coverage of deprecated behavior rather than to raise deprecation warnings as part of unrelated operations.

On Tue, Oct 30, 2018 at 3:06 PM Deepak Cherian notifications@github.com wrote:

@dcherian commented on this pull request.

In xarray/tests/test_dataarray.py https://github.com/pydata/xarray/pull/2524#discussion_r229503613:

@@ -23,6 +23,7 @@ requires_scipy, source_ndarray)

+@pytest.mark.filterwarnings('ignore:The inplace argument')

Oh I haven't checked that closely but I can do that tonight. (my impression was that the tests were testing inplace behaviour, but I see that could be wrong)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/2524#discussion_r229503613, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1nCL0fqW2POPBepyKA2R4lxQGGONks5uqM1ZgaJpZM4X-bI- . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   374849806