issues

Table actions

2 rows where type = "pull" and user = 2501846 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date), closed_at (date)

type 1

  • pull · 2 ✖

state 1

repo 1

id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1897556803 PR_kwDOAMm_X85aZTCR 8186 Update contourf call check for mpl 3.8 ksunden 2501846 closed 0     0 2023-09-15T01:30:40Z 2023-09-16T19:28:06Z 2023-09-16T19:28:06Z CONTRIBUTOR   0 pydata/xarray/pulls/8186

In doing the final checks prior to release of Matplotlib 3.8.0, we noticed that there were two test failures here due to the return type/artist tree changing for contourf calls (while the type is reasonably back-compatible itself, we have moved from a "QuadContourSet makes a PathCollection" to "QuadContourSet is a full artist/collection"

xref matplotlib/matplotlib#25247

Unfortunately this change is not really possible to make with deprecations/etc, so we are kind of stuck just making it. However, in practice, it has only ever seemed to matter for test code which is pretty easy to make work (like here),r so we have decided to go forward with the change.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8186/reactions",
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1683839855 PR_kwDOAMm_X85PI5DH 7786 Use canonical name for set_horizonalalignment over alias set_ha ksunden 2501846 closed 0     3 2023-04-25T20:45:26Z 2023-04-26T15:10:47Z 2023-04-26T15:10:44Z CONTRIBUTOR   0 pydata/xarray/pulls/7786

Matplotlib has recently introduced type hints on our main version (due to be released with mpl v3.8 in a couple months) xref matplotlib/matplotlib#24976

As part of this, the dynamically generated aliases of certain functions are not included in static type hints (since they are dynamic). So, a type hinted codebase should prefer the canonical names so that they can be type checked.

I encourage maintainers over here to run type checking with our new type hints, as this is not the only thing flagged. Much of the remaining flags have to do with interactions with 3D axes, which are currently not type hinted in mpl (along with the rest of mpl_toolkits, for that matter).

Feel free to ping me if you have any questions regarding mpl's type hints and interactions here. Partly opening this as a "reach out early, so you don't get surprised by a release breaking CI" (and can hopefully sort it out before that a bit more incrementally).

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7786/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);