issues: 1683839855
This data as json
| id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| 1683839855 | PR_kwDOAMm_X85PI5DH | 7786 | Use canonical name for set_horizonalalignment over alias set_ha | 2501846 | closed | 0 | 3 | 2023-04-25T20:45:26Z | 2023-04-26T15:10:47Z | 2023-04-26T15:10:44Z | CONTRIBUTOR | 0 | pydata/xarray/pulls/7786 | Matplotlib has recently introduced type hints on our main version (due to be released with mpl v3.8 in a couple months) xref matplotlib/matplotlib#24976 As part of this, the dynamically generated aliases of certain functions are not included in static type hints (since they are dynamic). So, a type hinted codebase should prefer the canonical names so that they can be type checked. I encourage maintainers over here to run type checking with our new type hints, as this is not the only thing flagged. Much of the remaining flags have to do with interactions with 3D axes, which are currently not type hinted in mpl (along with the rest of mpl_toolkits, for that matter). Feel free to ping me if you have any questions regarding mpl's type hints and interactions here. Partly opening this as a "reach out early, so you don't get surprised by a release breaking CI" (and can hopefully sort it out before that a bit more incrementally). |
{
"url": "https://api.github.com/repos/pydata/xarray/issues/7786/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
13221727 | pull |