issues: 1897556803
This data as json
id | node_id | number | title | user | state | locked | assignee | milestone | comments | created_at | updated_at | closed_at | author_association | active_lock_reason | draft | pull_request | body | reactions | performed_via_github_app | state_reason | repo | type |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
1897556803 | PR_kwDOAMm_X85aZTCR | 8186 | Update contourf call check for mpl 3.8 | 2501846 | closed | 0 | 0 | 2023-09-15T01:30:40Z | 2023-09-16T19:28:06Z | 2023-09-16T19:28:06Z | CONTRIBUTOR | 0 | pydata/xarray/pulls/8186 | In doing the final checks prior to release of Matplotlib 3.8.0, we noticed that there were two test failures here due to the return type/artist tree changing for contourf calls (while the type is reasonably back-compatible itself, we have moved from a "QuadContourSet makes a PathCollection" to "QuadContourSet is a full artist/collection" xref matplotlib/matplotlib#25247 Unfortunately this change is not really possible to make with deprecations/etc, so we are kind of stuck just making it. However, in practice, it has only ever seemed to matter for test code which is pretty easy to make work (like here),r so we have decided to go forward with the change. |
{ "url": "https://api.github.com/repos/pydata/xarray/issues/8186/reactions", "total_count": 2, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
13221727 | pull |