issues

Table actions

15 rows where repo = 13221727, type = "pull" and user = 22245117 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: comments, draft, created_at (date), updated_at (date), closed_at (date)

type 1

  • pull · 15 ✖

state 1

repo 1

  • xarray · 15 ✖
id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1918317723 PR_kwDOAMm_X85bfKv_ 8253 fix zarr datetime64 chunks malmans2 22245117 closed 0     14 2023-09-28T21:48:32Z 2024-01-29T19:12:31Z 2024-01-29T19:12:31Z CONTRIBUTOR   0 pydata/xarray/pulls/8253
  • [x] Closes #8230
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8253/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1987252044 PR_kwDOAMm_X85fHv_I 8439 Restore dask arrays rather than editing encoding malmans2 22245117 closed 0     0 2023-11-10T09:32:23Z 2023-11-10T09:58:39Z 2023-11-10T09:58:39Z CONTRIBUTOR   1 pydata/xarray/pulls/8439

Just to show why restoring dask arrays rather than editing encoding does not work in #8253 

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8439/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1862636081 PR_kwDOAMm_X85Yj6RX 8101 Fix tokenize with empty attrs malmans2 22245117 closed 0     1 2023-08-23T06:13:05Z 2023-09-09T04:53:19Z 2023-09-09T04:53:19Z CONTRIBUTOR   0 pydata/xarray/pulls/8101
  • [x] Closes #6970
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst ~New functions/methods are listed in api.rst~
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/8101/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1746328632 PR_kwDOAMm_X85Sb9Mu 7900 fix polyfit changing the original object malmans2 22245117 closed 0     1 2023-06-07T17:00:21Z 2023-06-09T15:38:00Z 2023-06-09T15:37:59Z CONTRIBUTOR   0 pydata/xarray/pulls/7900
  • [x] Closes #5644
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

~New functions/methods are listed in api.rst~

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7900/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1605486189 PR_kwDOAMm_X85LDxq5 7575 fix nczarr when libnetcdf>4.8.1 malmans2 22245117 closed 0     1 2023-03-01T18:47:09Z 2023-03-02T16:49:23Z 2023-03-02T16:49:23Z CONTRIBUTOR   0 pydata/xarray/pulls/7575
  • [x] Closes #7572
  • [x] Tests added

~User visible changes (including notable bug fixes) are documented in whats-new.rst~ ~New functions/methods are listed in api.rst~

The latest version of netcdf-c does not allow writing a NCZarr file without the xarray's _ARRAY_DIMENSIONS attribute. Also, nczarr attributes are now lowercase.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/7575/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1248389852 PR_kwDOAMm_X844dcln 6636 Use `zarr` to validate attrs when writing to zarr malmans2 22245117 closed 0     2 2022-05-25T16:46:03Z 2022-06-03T18:48:54Z 2022-06-03T18:48:48Z CONTRIBUTOR   0 pydata/xarray/pulls/6636
  • [x] Closes #6448
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • ~New functions/methods are listed in api.rst~

I think we can just use zarr to validate attributes, so we can support all types allowed by zarr.

Note that I removed the checks on the keys, as I believe we can rely on zarr for that as well. However, there is an issue with mixed types (e.g., attrs={"a": "foo", 1: "foo"}), but I think that needs to be addressed in zarr. See: https://github.com/zarr-developers/zarr-python/issues/1037

cc: @wankoelias @rabernat 

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6636/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
1183534905 PR_kwDOAMm_X841KS8J 6420 Add support in the "zarr" backend for reading NCZarr data malmans2 22245117 closed 0     6 2022-03-28T14:32:27Z 2022-04-14T15:36:14Z 2022-04-14T15:36:05Z CONTRIBUTOR   0 pydata/xarray/pulls/6420
  • [x] Closes #6374
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • ~New functions/methods are listed in api.rst~
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6420/reactions",
    "total_count": 2,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 2,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
926503178 MDExOlB1bGxSZXF1ZXN0Njc0Nzk4NTAz 5507 specify typing-extensions version malmans2 22245117 closed 0     1 2021-06-21T18:58:50Z 2021-07-02T12:45:35Z 2021-07-02T12:45:35Z CONTRIBUTOR   0 pydata/xarray/pulls/5507
  • [x] Passes pre-commit run --all-files

See: https://github.com/pydata/xarray/pull/5503#discussion_r655550526

cc: @dcherian 

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5507/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
925981767 MDExOlB1bGxSZXF1ZXN0Njc0MzUxMjQw 5503 Add typing-extensions to dependencies malmans2 22245117 closed 0     3 2021-06-21T08:47:44Z 2021-06-21T16:51:18Z 2021-06-21T15:13:21Z CONTRIBUTOR   0 pydata/xarray/pulls/5503
  • [x] Closes #5495
  • [x] Passes pre-commit run --all-files
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5503/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
912932344 MDExOlB1bGxSZXF1ZXN0NjYzMDM3MzU0 5445 Add `xr.unify_chunks()` top level method malmans2 22245117 closed 0     7 2021-06-06T19:51:47Z 2021-06-21T08:53:40Z 2021-06-16T14:56:59Z CONTRIBUTOR   0 pydata/xarray/pulls/5445
  • [x] Closes #3371
  • [x] Tests added
  • [x] Passes pre-commit run --all-files
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [x] New functions/methods are listed in api.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5445/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
904865813 MDExOlB1bGxSZXF1ZXN0NjU1OTg2NTg4 5393 Don't drop unreduced variables malmans2 22245117 closed 0     4 2021-05-28T07:40:30Z 2021-06-21T08:53:31Z 2021-06-12T17:45:00Z CONTRIBUTOR   0 pydata/xarray/pulls/5393
  • [x] Closes #5368
  • [x] Tests added
  • [x] Passes pre-commit run --all-files
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

Reduce methods such as mean drop non-numeric variables. However, there's no need to drop variables that are not actually reduced (i.e., when "reduce_dim" not in da.dims).

cc: @rcaneill

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5393/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
904934839 MDExOlB1bGxSZXF1ZXN0NjU2MDQ5NDcx 5394 Allow selecting variables using a list with mixed data types malmans2 22245117 closed 0     2 2021-05-28T08:24:23Z 2021-06-21T08:53:29Z 2021-06-12T17:44:05Z CONTRIBUTOR   0 pydata/xarray/pulls/5394
  • [x] Closes #5387
  • [x] Tests added
  • [x] Passes pre-commit run --all-files
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

Lists passed to __getitem__ are converted to arrays. np.asarray infers the dtype, and for example converts a list with str and int to an array of str. Forcing dtype="O" fixes the issue.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5394/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
912477313 MDExOlB1bGxSZXF1ZXN0NjYyNjMyNzI2 5440 Consistent chunking after broadcasting malmans2 22245117 closed 0     1 2021-06-05T22:27:39Z 2021-06-21T08:53:12Z 2021-06-21T08:53:09Z CONTRIBUTOR   0 pydata/xarray/pulls/5440
  • [x] Closes #5435
  • [ ] Tests added
  • [x] Passes pre-commit run --all-files
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

I think it does the job, although I'm not sure whether this is the best approach. A couple of questions: 1. I should probably add a test. Where is the best place? test_dask? 2. I added a chunks arguments in set_dims. I haven't updated the docstring yet... i) shape is not in the docstring either, is it because it is not meant to be public? If yes, I guess we can omit chunks as well. ii) The chunks argument I've introduced must be a dict mapping dim to chunks. Is that a problem since chunks is used elsewhere and can be slightly different (e.g., just an integer, 'auto'). iii) Should I add a check and raise an error if chunks is not a dictionary or is missing dimensions?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5440/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
898841079 MDExOlB1bGxSZXF1ZXN0NjUwNjU2MDg1 5362 Check dimensions before applying weighted operations malmans2 22245117 closed 0     4 2021-05-22T16:51:54Z 2021-05-23T23:45:47Z 2021-05-23T23:45:47Z CONTRIBUTOR   0 pydata/xarray/pulls/5362
  • [x] Closes #5354
  • [x] Tests added
  • [x] Passes pre-commit run --all-files
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5362/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull
841097432 MDExOlB1bGxSZXF1ZXN0NjAwODgxNzE4 5076 Improve map_blocks docs malmans2 22245117 closed 0     1 2021-03-25T16:23:35Z 2021-03-29T17:46:02Z 2021-03-29T17:45:59Z CONTRIBUTOR   0 pydata/xarray/pulls/5076
  • [x] Closes #5071
  • [x] Passes pre-commit run --all-files
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5076/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     xarray 13221727 pull

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [active_lock_reason] TEXT,
   [draft] INTEGER,
   [pull_request] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [state_reason] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
);
CREATE INDEX [idx_issues_repo]
    ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
    ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
    ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
    ON [issues] ([user]);