issues: 1248389852

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
1248389852 PR_kwDOAMm_X844dcln 6636 Use `zarr` to validate attrs when writing to zarr 22245117 closed 0     2 2022-05-25T16:46:03Z 2022-06-03T18:48:54Z 2022-06-03T18:48:48Z CONTRIBUTOR   0 pydata/xarray/pulls/6636
  • [x] Closes #6448
  • [x] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • ~New functions/methods are listed in api.rst~

I think we can just use zarr to validate attributes, so we can support all types allowed by zarr.

Note that I removed the checks on the keys, as I believe we can rely on zarr for that as well. However, there is an issue with mixed types (e.g., attrs={"a": "foo", 1: "foo"}), but I think that needs to be addressed in zarr. See: https://github.com/zarr-developers/zarr-python/issues/1037

cc: @wankoelias @rabernat 

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/6636/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables