issues: 912477313

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
912477313 MDExOlB1bGxSZXF1ZXN0NjYyNjMyNzI2 5440 Consistent chunking after broadcasting 22245117 closed 0     1 2021-06-05T22:27:39Z 2021-06-21T08:53:12Z 2021-06-21T08:53:09Z CONTRIBUTOR   0 pydata/xarray/pulls/5440
  • [x] Closes #5435
  • [ ] Tests added
  • [x] Passes pre-commit run --all-files
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

I think it does the job, although I'm not sure whether this is the best approach. A couple of questions: 1. I should probably add a test. Where is the best place? test_dask? 2. I added a chunks arguments in set_dims. I haven't updated the docstring yet... i) shape is not in the docstring either, is it because it is not meant to be public? If yes, I guess we can omit chunks as well. ii) The chunks argument I've introduced must be a dict mapping dim to chunks. Is that a problem since chunks is used elsewhere and can be slightly different (e.g., just an integer, 'auto'). iii) Should I add a check and raise an error if chunks is not a dictionary or is missing dimensions?

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5440/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables