issue_comments

Table actions

8 rows where user = 31115101 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, reactions, created_at (date), updated_at (date)

user 1

  • lilyminium · 8 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
851688260 https://github.com/pydata/xarray/pull/2533#issuecomment-851688260 https://api.github.com/repos/pydata/xarray/issues/2533 MDEyOklzc3VlQ29tbWVudDg1MTY4ODI2MA== lilyminium 31115101 2021-05-31T21:22:01Z 2021-05-31T21:22:01Z CONTRIBUTOR

context

I can only find references regarding ufuncs in the numpy docs when I look up the context. I would think that in that case the shapes should be fine, but please do correct me if not?

_unary_op calls __array_wrap__(context=None); if the function only checks the shape when context is None and a dummy value gets passed in for the context, that's one way to avoid it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Check shapes of coordinates and data during DataArray construction 376167325
851614917 https://github.com/pydata/xarray/pull/2533#issuecomment-851614917 https://api.github.com/repos/pydata/xarray/issues/2533 MDEyOklzc3VlQ29tbWVudDg1MTYxNDkxNw== lilyminium 31115101 2021-05-31T17:46:49Z 2021-05-31T17:46:49Z CONTRIBUTOR

The 3.7 test looks like an installation error.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Check shapes of coordinates and data during DataArray construction 376167325
851599339 https://github.com/pydata/xarray/pull/2533#issuecomment-851599339 https://api.github.com/repos/pydata/xarray/issues/2533 MDEyOklzc3VlQ29tbWVudDg1MTU5OTMzOQ== lilyminium 31115101 2021-05-31T17:01:25Z 2021-05-31T17:01:25Z CONTRIBUTOR

Hmmmm. It's been quite some time since I've last used xarray, but I'm not sure I see an easy way to:

  1. hijack np.insert (which I would guess goes directly to DataArray.__array_wrap__ / __array_finalize__)
  2. without passing a fastpath-like argument to __array_wrap__, but
  3. efficiently not checking the shape of safe operations, like _unary_op.

I have for now stuck fastpath in _replace but it fails condition 3 and just runs for all calls to __array_wrap__.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Check shapes of coordinates and data during DataArray construction 376167325
850606084 https://github.com/pydata/xarray/pull/2533#issuecomment-850606084 https://api.github.com/repos/pydata/xarray/issues/2533 MDEyOklzc3VlQ29tbWVudDg1MDYwNjA4NA== lilyminium 31115101 2021-05-28T18:55:14Z 2021-05-28T18:55:14Z CONTRIBUTOR

Ooh, this is a blast from the past. Anyone passing by, feel free to pick this up if you like, otherwise I'll see what I can do over the weekend :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Check shapes of coordinates and data during DataArray construction 376167325
482404244 https://github.com/pydata/xarray/pull/2530#issuecomment-482404244 https://api.github.com/repos/pydata/xarray/issues/2530 MDEyOklzc3VlQ29tbWVudDQ4MjQwNDI0NA== lilyminium 31115101 2019-04-12T01:47:17Z 2019-04-12T01:47:17Z CONTRIBUTOR

Hi @lilyminium - I appreciate your patience with this. I think we are almost there!

We have a few failing tests. Zarr is raising a ValueError: missing object_codec for object array. This is pretty old, so I don't think it's due to an upstream zarr change.

Do you have any idea what might be going on here? I haven't had time to dig deep into it.

Whoops, I think I was looking at the unicode dtype and forgot which branch I was in, then ran tests in the wrong environment... hopefully fixed now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Manually specify chunks in open_zarr 376116903
442569498 https://github.com/pydata/xarray/pull/2559#issuecomment-442569498 https://api.github.com/repos/pydata/xarray/issues/2559 MDEyOklzc3VlQ29tbWVudDQ0MjU2OTQ5OA== lilyminium 31115101 2018-11-28T19:15:33Z 2018-11-28T19:15:33Z CONTRIBUTOR

I remember dealing with this in my pull request -- if I recall correctly scheduler was pointing to the scheduler.get function instead. It was a minor bug that was either fixed in the next release of xarray (0.11.0) or Dask (0.20.1).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Zarr consolidated 382497709
436474639 https://github.com/pydata/xarray/pull/2533#issuecomment-436474639 https://api.github.com/repos/pydata/xarray/issues/2533 MDEyOklzc3VlQ29tbWVudDQzNjQ3NDYzOQ== lilyminium 31115101 2018-11-07T01:50:06Z 2018-11-07T01:50:06Z CONTRIBUTOR

I think the clean way to fix this would be to add error checking to DataArray.__array_wrap__. But we currently use this method inside DataArray._unary_op (and maybe elsewhere?), which is called every time you do unwary math with an xarray object (e.g., -). We’ll want to update these uses to use a method that uses the same shortcut to avoid redundant metadata checks.

Does adding fastpath to skip shape checking in array_wrap work? fastpath=True in both DataArray.array_wrap and Variable.array_wrap didn't seem to break any tests.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Check shapes of coordinates and data during DataArray construction 376167325
434609224 https://github.com/pydata/xarray/pull/2487#issuecomment-434609224 https://api.github.com/repos/pydata/xarray/issues/2487 MDEyOklzc3VlQ29tbWVudDQzNDYwOTIyNA== lilyminium 31115101 2018-10-31T08:57:45Z 2018-10-31T08:57:45Z CONTRIBUTOR

Thanks for this contribution!

Can you add whatsnew entry in the docs as well?

We are still missing an entry in whatsnew. Please add it to give yourself credit for your contribution! :)

Forgot I hadn't done that yet, thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Zarr chunking (GH2300) 369935730

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);