issue_comments: 851599339

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2533#issuecomment-851599339 https://api.github.com/repos/pydata/xarray/issues/2533 851599339 MDEyOklzc3VlQ29tbWVudDg1MTU5OTMzOQ== 31115101 2021-05-31T17:01:25Z 2021-05-31T17:01:25Z CONTRIBUTOR

Hmmmm. It's been quite some time since I've last used xarray, but I'm not sure I see an easy way to:

  1. hijack np.insert (which I would guess goes directly to DataArray.__array_wrap__ / __array_finalize__)
  2. without passing a fastpath-like argument to __array_wrap__, but
  3. efficiently not checking the shape of safe operations, like _unary_op.

I have for now stuck fastpath in _replace but it fails condition 3 and just runs for all calls to __array_wrap__.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   376167325