home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 436474639

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/2533#issuecomment-436474639 https://api.github.com/repos/pydata/xarray/issues/2533 436474639 MDEyOklzc3VlQ29tbWVudDQzNjQ3NDYzOQ== 31115101 2018-11-07T01:50:06Z 2018-11-07T01:50:06Z CONTRIBUTOR

I think the clean way to fix this would be to add error checking to DataArray.__array_wrap__. But we currently use this method inside DataArray._unary_op (and maybe elsewhere?), which is called every time you do unwary math with an xarray object (e.g., -). We’ll want to update these uses to use a method that uses the same shortcut to avoid redundant metadata checks.

Does adding fastpath to skip shape checking in array_wrap work? fastpath=True in both DataArray.array_wrap and Variable.array_wrap didn't seem to break any tests.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  376167325
Powered by Datasette · Queries took 0.974ms · About: xarray-datasette