issue_comments

Table actions

4 rows where issue = 996475523 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • dcherian · 4 ✖

issue 1

  • Add asv benchmark jobs to CI · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
950296261 https://github.com/pydata/xarray/pull/5796#issuecomment-950296261 https://api.github.com/repos/pydata/xarray/issues/5796 IC_kwDOAMm_X844pF7F dcherian 2448579 2021-10-24T10:07:49Z 2021-10-24T10:07:49Z MEMBER

Thanks @Illviljan this is great work!

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add asv benchmark jobs to CI 996475523
923263203 https://github.com/pydata/xarray/pull/5796#issuecomment-923263203 https://api.github.com/repos/pydata/xarray/issues/5796 IC_kwDOAMm_X843B-Dj dcherian 2448579 2021-09-20T20:16:13Z 2021-09-20T20:16:13Z MEMBER

@dcherian did you have something specific in mind when you linked to https://github.com/jaimergp/scikit-image/blob/main/.github/workflows/benchmarks-cron.yml in #4648? I think I'll remove it otherwise and just focus on

Nothing specific. Just wanted to link their configuration.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add asv benchmark jobs to CI 996475523
920203704 https://github.com/pydata/xarray/pull/5796#issuecomment-920203704 https://api.github.com/repos/pydata/xarray/issues/5796 IC_kwDOAMm_X8422TG4 dcherian 2448579 2021-09-15T17:02:44Z 2021-09-15T17:02:44Z MEMBER

Ah one major problem IIUC is that we run a lot of benchmarks with and without bottleneck even if bottleneck isn't involved in the operation being benchmarked.

Some of the following should be fixed

ImportError: Pandas requires version '0.12.3' or newer of 'xarray' (version '0.0.0' currently installed).

rolling.Rolling.time_rolling_construct
xarray.core.merge.MergeError: conflicting values for variable 'x_coords' on objects to be combined. You can skip this check by specifying compat='override'.

IOWriteNetCDFDaskDistributed.time_write Looks like we're spinning up multiple dask clusters. UserWarning: Port 8787 is already in use. Perhaps you already have a cluster running? Hosting the HTTP server on port 33423 instead warnings.warn(

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add asv benchmark jobs to CI 996475523
920194613 https://github.com/pydata/xarray/pull/5796#issuecomment-920194613 https://api.github.com/repos/pydata/xarray/issues/5796 IC_kwDOAMm_X8422Q41 dcherian 2448579 2021-09-15T16:53:10Z 2021-09-15T16:53:10Z MEMBER

Long times, +240 minutes

yeah this is a problem.

Maybe we need to go through and mark the slow tests like in the README_ci.md document

In that vein, a new private function is defined at benchmarks.__init__: _skip_slow. This will check if the ASV_SKIP_SLOW environment variable has been defined. If set to 1, it will raise NotImplementedError and skip the test. To implement this behavior in other tests, you can add the following attribute:

Add more required installs? bottleneck for examples crashes tests because it isn't installed. Add all the non-required as well?

Do you mean skipping those that require bottleneck rather than relying on asv to handle the crash? If so, sounds good

Can a normal user add and remove labels?

An alternative approach would be to use something similar to our [skip-ci] and [test-upstream] tags in the commit message. Though I think that tag needs to be on every commit you want benchmarked.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add asv benchmark jobs to CI 996475523

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);