issues: 996475523

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
996475523 PR_kwDOAMm_X84rwPey 5796 Add asv benchmark jobs to CI 14371165 closed 0     16 2021-09-14T22:00:49Z 2022-08-12T09:01:15Z 2021-10-24T10:08:02Z MEMBER   0 pydata/xarray/pulls/5796

Workflow based on the version from scikit-image. Modfied to have asv.conf.json inside a subdirectory and triggers every push if the PR has the run-benchmark label.

Notes: * https://github.com/scikit-image/scikit-image doesn't have the same benchmark folder setup, for example config file is in root directory, other folder names. * https://github.com/numpy/numpy has same folder name as sckit-image. config file is in the folder however.

References: * https://labs.quansight.org/blog/2021/08/github-actions-benchmarks/ * https://github.com/scikit-image/scikit-image/pull/5424 * https://github.com/jaimergp/scikit-image/pull/1

Tests checked:

  • [x] interp
  • [x] pandas
  • [x] repr
  • [x] combine
  • [x] datarray_missing
  • [x] dataset_io - Skipped too difficult to understand. Some of the tests are possibly broken.
  • [x] indexing
  • [x] reindexing
  • [x] rolling - Some division by 0 prints left.
  • [x] unstacking

TODO: * self.setup_cache

  • [x] Related to #4648
  • [x] Tests added
  • [x] Passes pre-commit run --all-files
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/5796/reactions",
    "total_count": 2,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 2,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables