issue_comments: 910464246

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/5755#issuecomment-910464246 https://api.github.com/repos/pydata/xarray/issues/5755 910464246 IC_kwDOAMm_X842RJT2 5635139 2021-09-01T16:46:03Z 2021-09-01T16:47:01Z MEMBER

Edit: @Illviljan and I commented at the same time, he seems to have found the error!

Great spot @benbovy . I think what's happening is that the standard run only checks .py files, rather than .pyi files. So mypy . collects it, but pre-commit and mypy doesn't.

ref https://github.com/pre-commit/mirrors-mypy/issues/33 for the pre-commit issue.

On the errors themselves — @rhkleijn I think I have upset your magnum opus despite the best of intentions. If you're up for having a look, that would be great. Otherwise we could try and revert my original PR, though I worry this sort of refactor is difficult to revert.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   985162305