issue_comments

Table actions

3 rows where issue = 977544678 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • dcherian · 3 ✖

issue 1

  • Shoudn't `assert_allclose` transpose datasets? · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
908433305 https://github.com/pydata/xarray/issues/5733#issuecomment-908433305 https://api.github.com/repos/pydata/xarray/issues/5733 IC_kwDOAMm_X842JZeZ dcherian 2448579 2021-08-30T15:20:29Z 2021-08-30T15:20:29Z MEMBER

what the default comparison behaviour should be

I don't think we can change this because it's very backwards incompatible and affects tests in downstream packages.

But :+1: to adding a flag allowing users to opt out of dimension order checking.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Shoudn't `assert_allclose` transpose datasets? 977544678
907901984 https://github.com/pydata/xarray/issues/5733#issuecomment-907901984 https://api.github.com/repos/pydata/xarray/issues/5733 IC_kwDOAMm_X842HXwg dcherian 2448579 2021-08-29T23:50:59Z 2021-08-29T23:50:59Z MEMBER

I have a related question

``` python import xarray as xr

da = xr.DataArray([[1, 1, 1], [2, 2, 2]], dims=("x", "y"))

xr.testing.assert_identical(da, da.transpose()) AssertionError: Left and right DataArray objects are not identical Differing dimensions: (x: 2, y: 3) != (y: 3, x: 2) Differing values: L array([[1, 1, 1], [2, 2, 2]]) R array([[1, 2], [1, 2], [1, 2]]) ```

Strictly speaking, the values are different I guess. However I think this error would be clearer if it said that the dimension order was different but the values are equal once the dimensions are transposed.

I.e. we could

python if set(a.dims) == set(b.dims): a = a.transpose(b.dims) # check values and raise if actually different else: # current behaviour

Is this a good idea?

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Shoudn't `assert_allclose` transpose datasets? 977544678
904683190 https://github.com/pydata/xarray/issues/5733#issuecomment-904683190 https://api.github.com/repos/pydata/xarray/issues/5733 IC_kwDOAMm_X8417F62 dcherian 2448579 2021-08-24T14:16:45Z 2021-08-24T14:16:45Z MEMBER

What about a check_dim_order option? Also, it would be useful if information about non-matching dimension order was shown more explicitly in the assertion error message.

This sounds good to me. We should also have a check_attrs kwarg since that's another thing that only identical checks.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Shoudn't `assert_allclose` transpose datasets? 977544678

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);