issue_comments

Table actions

2 rows where issue = 843961481 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 2 ✖

issue 1

  • Add unique method · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
813520134 https://github.com/pydata/xarray/pull/5091#issuecomment-813520134 https://api.github.com/repos/pydata/xarray/issues/5091 MDEyOklzc3VlQ29tbWVudDgxMzUyMDEzNA== shoyer 1217238 2021-04-05T17:27:49Z 2021-04-05T17:27:49Z MEMBER

Let's sort out drop_duplicates (https://github.com/pydata/xarray/pull/5089) first. I imagine unique() could be a special case of the exact same logic.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add unique method 843961481
812108370 https://github.com/pydata/xarray/pull/5091#issuecomment-812108370 https://api.github.com/repos/pydata/xarray/issues/5091 MDEyOklzc3VlQ29tbWVudDgxMjEwODM3MA== shoyer 1217238 2021-04-01T19:00:13Z 2021-04-01T19:00:13Z MEMBER

We don't have precedent for methods that return a numpy array. But it's unclear what xarray object this would return.

There is a precedent in xarray (it might be the only one):

In [2]: xr.DataArray([1,2,3,4,5]).searchsorted([-10, 10, 2, 3]) Out[2]: array([0, 5, 1, 2])

I think searchsorted was probably a mistake from the very early days of Xarray.

I would lean against adding unique. These functions are very short to write (and thus easy to reproduce in user code), so it's not clear that the cost/benefit is worth it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add unique method 843961481

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);