issue_comments: 812108370

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/5091#issuecomment-812108370 https://api.github.com/repos/pydata/xarray/issues/5091 812108370 MDEyOklzc3VlQ29tbWVudDgxMjEwODM3MA== 1217238 2021-04-01T19:00:13Z 2021-04-01T19:00:13Z MEMBER

We don't have precedent for methods that return a numpy array. But it's unclear what xarray object this would return.

There is a precedent in xarray (it might be the only one):

In [2]: xr.DataArray([1,2,3,4,5]).searchsorted([-10, 10, 2, 3]) Out[2]: array([0, 5, 1, 2])

I think searchsorted was probably a mistake from the very early days of Xarray.

I would lean against adding unique. These functions are very short to write (and thus easy to reproduce in user code), so it's not clear that the cost/benefit is worth it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   843961481