issue_comments

Table actions

6 rows where issue = 729208432 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • numpy_groupies · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
902670118 https://github.com/pydata/xarray/pull/4540#issuecomment-902670118 https://api.github.com/repos/pydata/xarray/issues/4540 IC_kwDOAMm_X841zacm tlogan2000 22454970 2021-08-20T12:54:07Z 2021-08-20T12:54:07Z NONE

FYI @aulemahal @Zeitsperre @huard ... re: xclim discussion yesterday. If we have spare moments in the following weeks we could try a few tests on our to end to benchmark and provide bug reports

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   numpy_groupies 729208432
902257325 https://github.com/pydata/xarray/pull/4540#issuecomment-902257325 https://api.github.com/repos/pydata/xarray/issues/4540 IC_kwDOAMm_X841x1qt dcherian 2448579 2021-08-19T21:22:52Z 2021-08-19T21:22:52Z MEMBER

Hi @tlogan2000 , this is moving forward but slowly.

The good news is that I got resampling working this week (at least for some minimal test cases). It works by rechunking so that every chunk boundary lines up with a group boundary, and then applies numpy_groupies blockwise.

https://github.com/dcherian/dask_groupby/blob/8a30c4b20f23acacfc3b53dbeab2a7b268ecd3fc/dask_groupby/xarray.py#L268-L272

You can test it out with something like this python dask_groupby.xarray.resample_reduce(ds.resample(time="M"), func="mean")

For general groupby use python dask_groupby.xarray.xarray_reduce(...) This still fails a few xarray tests but a lot of them pass! Let me know how it goes and please file bug reports over at the dask_groupby repo if you find any.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   numpy_groupies 729208432
902148007 https://github.com/pydata/xarray/pull/4540#issuecomment-902148007 https://api.github.com/repos/pydata/xarray/issues/4540 IC_kwDOAMm_X841xa-n tlogan2000 22454970 2021-08-19T18:35:48Z 2021-08-19T18:35:48Z NONE

Hello all, my fellow xclim https://github.com/Ouranosinc/xclim devs and I would be interested to know if this PR is still moving forward? xr.resample is pretty fundamental to much of our package so we are definitely interested in seeing the possibility of improved performance.

cheers

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   numpy_groupies 729208432
865398930 https://github.com/pydata/xarray/pull/4540#issuecomment-865398930 https://api.github.com/repos/pydata/xarray/issues/4540 MDEyOklzc3VlQ29tbWVudDg2NTM5ODkzMA== dcherian 2448579 2021-06-21T23:02:20Z 2021-06-21T23:02:20Z MEMBER

No worries @max-sixty! It looks like @andersy005 will be trying to get this completed soon

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   numpy_groupies 729208432
864594346 https://github.com/pydata/xarray/pull/4540#issuecomment-864594346 https://api.github.com/repos/pydata/xarray/issues/4540 MDEyOklzc3VlQ29tbWVudDg2NDU5NDM0Ng== max-sixty 5635139 2021-06-20T18:32:11Z 2021-06-20T18:32:11Z MEMBER

@dcherian I know we discussed this a couple of weeks ago, and I said I was hoping to take another pass at this using https://github.com/dcherian/dask_groupby

For transparency, I haven't managed to spend any time on this yet. I certainly don't want to block you if you're interested in taking this forward.

FWIW my selfish motivation is more around speeding up in-memory groupbys than dask groupbys — the elegance of numpy_groupies & dask_groupby is that they can potentially be unified.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   numpy_groupies 729208432
792460981 https://github.com/pydata/xarray/pull/4540#issuecomment-792460981 https://api.github.com/repos/pydata/xarray/issues/4540 MDEyOklzc3VlQ29tbWVudDc5MjQ2MDk4MQ== max-sixty 5635139 2021-03-08T04:53:33Z 2021-03-08T04:53:33Z MEMBER

Cheers @dcherian . I've been a bit absent from xarray features for the past couple of months as you know.

If you want to take this on, please feel free. It's still at the top of my list — so I would get to it — but I really don't want to slow the progress. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   numpy_groupies 729208432

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);