issues: 729208432

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
729208432 MDExOlB1bGxSZXF1ZXN0NTA5NzM0NTM2 4540 numpy_groupies 5635139 closed 0     6 2020-10-26T03:37:19Z 2022-02-05T22:24:12Z 2021-10-24T00:18:52Z MEMBER   0 pydata/xarray/pulls/4540
  • [x] Closes https://github.com/pydata/xarray/issues/4473
  • [ ] Tests added
  • [x] Passes isort . && black . && mypy . && flake8
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst
  • [ ] New functions/methods are listed in api.rst

Very early effort — I found this harder than I expected — I was trying to use the existing groupby infra, but think I maybe should start afresh. The result of the numpy_groupies operation is a fully formed array, whereas we're used to handling an iterable of results which need to be concat.

I also added some type signature / notes and I was going through the existing code; mostly for my own understanding

If anyone has any thoughts, feel free to comment — otherwise I'll resume this soon

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4540/reactions",
    "total_count": 4,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 2,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables