issue_comments

Table actions

17 rows where issue = 728888328 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • Add isocalendar to dt fields · 17 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
729813138 https://github.com/pydata/xarray/pull/4534#issuecomment-729813138 https://api.github.com/repos/pydata/xarray/issues/4534 MDEyOklzc3VlQ29tbWVudDcyOTgxMzEzOA== max-sixty 5635139 2020-11-18T16:58:25Z 2020-11-18T16:58:25Z MEMBER

Perfect. Thanks @mathause 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isocalendar to dt fields 728888328
729552267 https://github.com/pydata/xarray/pull/4534#issuecomment-729552267 https://api.github.com/repos/pydata/xarray/issues/4534 MDEyOklzc3VlQ29tbWVudDcyOTU1MjI2Nw== mathause 10194086 2020-11-18T09:28:53Z 2020-11-18T09:28:53Z MEMBER

Thanks! I moved

rst DataArray.dt.weekofyear DataArray.dt.week to Deprecated / Pending Deprecation in api.rst. I'll merge tomorrow.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isocalendar to dt fields 728888328
727292779 https://github.com/pydata/xarray/pull/4534#issuecomment-727292779 https://api.github.com/repos/pydata/xarray/issues/4534 MDEyOklzc3VlQ29tbWVudDcyNzI5Mjc3OQ== max-sixty 5635139 2020-11-15T01:38:25Z 2020-11-15T01:38:25Z MEMBER

Sorry this has been hanging for a while — I just resolved a conflict — feel free to merge on green!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isocalendar to dt fields 728888328
720165105 https://github.com/pydata/xarray/pull/4534#issuecomment-720165105 https://api.github.com/repos/pydata/xarray/issues/4534 MDEyOklzc3VlQ29tbWVudDcyMDE2NTEwNQ== keewis 14808389 2020-11-01T22:58:09Z 2020-11-01T23:20:25Z MEMBER

it does, at least locally. Not sure if it did before the merge. The RTD build is still running, though.

Edit: fixed

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isocalendar to dt fields 728888328
720164789 https://github.com/pydata/xarray/pull/4534#issuecomment-720164789 https://api.github.com/repos/pydata/xarray/issues/4534 MDEyOklzc3VlQ29tbWVudDcyMDE2NDc4OQ== mathause 10194086 2020-11-01T22:55:28Z 2020-11-01T22:55:28Z MEMBER

It seems to work after merging master: https://xray--4534.org.readthedocs.build/en/4534/whats-new.html

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isocalendar to dt fields 728888328
720162338 https://github.com/pydata/xarray/pull/4534#issuecomment-720162338 https://api.github.com/repos/pydata/xarray/issues/4534 MDEyOklzc3VlQ29tbWVudDcyMDE2MjMzOA== keewis 14808389 2020-11-01T22:33:49Z 2020-11-01T22:34:02Z MEMBER

unfortunately the restart didn't help. I'll try to run the build locally and debug

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isocalendar to dt fields 728888328
720156284 https://github.com/pydata/xarray/pull/4534#issuecomment-720156284 https://api.github.com/repos/pydata/xarray/issues/4534 MDEyOklzc3VlQ29tbWVudDcyMDE1NjI4NA== mathause 10194086 2020-11-01T21:42:53Z 2020-11-01T21:42:53Z MEMBER

Thanks for the hints @keewis! Unfortunately I wasn't really successful in building the docs locally. isocalendar throws a warning but it worked on RDT. Not sure what goes wrong locally. I'll try to figure this out another time, maybe something has the wrong version.

Thus, I isocalendar was not in objects.inv, but I think attr and meth should be correct.

Warnings

`WARNING: [autosummary] failed to import 'xarray.DataArray.dt.isocalendar': no module named xarray.DataArray.dt.isocalendar` and `WARNING: [autosummary] failed to import 'xarray.core.accessor_dt.DatetimeAccessor.isocalendar': no module named xarray.core.accessor_dt.DatetimeAccessor.isocalendar` 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isocalendar to dt fields 728888328
720145456 https://github.com/pydata/xarray/pull/4534#issuecomment-720145456 https://api.github.com/repos/pydata/xarray/issues/4534 MDEyOklzc3VlQ29tbWVudDcyMDE0NTQ1Ng== mathause 10194086 2020-11-01T20:18:58Z 2020-11-01T21:31:04Z MEMBER

Ok, this should work. Two open questions

  1. It's dt.isocalendar().day in pandas but its actually the weekday. I very much prefer dt.isocalendar().weekday. Are we ok with deviating from pandas?
  2. Should we deprecate week and weekofyear as pandas does? It's easier to do dt.week than dt.isocalendar().week. But dt.week might be ambiguous. (I added the deprecation but I am fine either way). TODO: move them to the deprecated api section.
  3. ~Would be good if someone could double-check the :py:attr: in whats-new (should it be :py:meth:?).~ I think this should be correct now.
 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isocalendar to dt fields 728888328
720147763 https://github.com/pydata/xarray/pull/4534#issuecomment-720147763 https://api.github.com/repos/pydata/xarray/issues/4534 MDEyOklzc3VlQ29tbWVudDcyMDE0Nzc2Mw== keewis 14808389 2020-11-01T20:37:03Z 2020-11-01T21:18:39Z MEMBER

@mathause, the way to check for the appropriate role is either by trial-and-error (check whether the build completes or the built page looks fine) or calling sh python -m sphinx.ext.intersphinx /path/to/objects.inv | less where objects.inv is in the _build/html directory. The path can also be a URL, in which case the file it points to will be downloaded and displayed.

The output is divided by role, so searching for the term you want to reference will give you the correct role.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isocalendar to dt fields 728888328
719992211 https://github.com/pydata/xarray/pull/4534#issuecomment-719992211 https://api.github.com/repos/pydata/xarray/issues/4534 MDEyOklzc3VlQ29tbWVudDcxOTk5MjIxMQ== spencerkclark 6628425 2020-10-31T21:44:01Z 2020-10-31T21:44:01Z MEMBER

Oh right...thanks @mathause.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isocalendar to dt fields 728888328
719988824 https://github.com/pydata/xarray/pull/4534#issuecomment-719988824 https://api.github.com/repos/pydata/xarray/issues/4534 MDEyOklzc3VlQ29tbWVudDcxOTk4ODgyNA== mathause 10194086 2020-10-31T21:10:41Z 2020-10-31T21:10:41Z MEMBER

Turns out times.isocalendar().year != times.year.... https://en.wikipedia.org/wiki/ISO_week_date

Check: python import pandas as pd times = pd.date_range(start="2000/01/01", freq="H", periods=100) times.isocalendar().year so I guess we need this second code path...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isocalendar to dt fields 728888328
719840720 https://github.com/pydata/xarray/pull/4534#issuecomment-719840720 https://api.github.com/repos/pydata/xarray/issues/4534 MDEyOklzc3VlQ29tbWVudDcxOTg0MDcyMA== max-sixty 5635139 2020-10-30T23:17:49Z 2020-10-30T23:17:49Z MEMBER

Amazing, thanks, that's great! Returning a Dataset is clever, I'm :+1:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isocalendar to dt fields 728888328
719810471 https://github.com/pydata/xarray/pull/4534#issuecomment-719810471 https://api.github.com/repos/pydata/xarray/issues/4534 MDEyOklzc3VlQ29tbWVudDcxOTgxMDQ3MQ== mathause 10194086 2020-10-30T21:34:24Z 2020-10-30T21:50:43Z MEMBER

I think day and year are still available in the pandas implementation though? It's only week that's going

True, I missed that.

I'd be very happy for someone else to take this on...

I hope I understood this correctly & you don't mind me pushing to your branch.

See the code for my suggestion (tests still missing). I think we need to return a Dataset for isocalendar. The way it's done is a bit inefficient (year and day is computed twice) but we avoid a second code-path. I don't have a strong opinion on deprecating time.dt.week or not.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isocalendar to dt fields 728888328
719786800 https://github.com/pydata/xarray/pull/4534#issuecomment-719786800 https://api.github.com/repos/pydata/xarray/issues/4534 MDEyOklzc3VlQ29tbWVudDcxOTc4NjgwMA== max-sixty 5635139 2020-10-30T20:40:17Z 2020-10-30T20:40:17Z MEMBER

CFTime defines day and year and I think it does not make sense if these have to be accessed through isocalendar()

I think day and year are still available in the pandas implementation though? It's only week that's going

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isocalendar to dt fields 728888328
719785555 https://github.com/pydata/xarray/pull/4534#issuecomment-719785555 https://api.github.com/repos/pydata/xarray/issues/4534 MDEyOklzc3VlQ29tbWVudDcxOTc4NTU1NQ== mathause 10194086 2020-10-30T20:37:37Z 2020-10-30T20:37:37Z MEMBER

CFTime defines day and year and I think it does not make sense if these have to be accessed through isocalendar()

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isocalendar to dt fields 728888328
716189888 https://github.com/pydata/xarray/pull/4534#issuecomment-716189888 https://api.github.com/repos/pydata/xarray/issues/4534 MDEyOklzc3VlQ29tbWVudDcxNjE4OTg4OA== max-sixty 5635139 2020-10-25T18:23:54Z 2020-10-25T18:23:54Z MEMBER

Do you think we should keep supporting week & weekofyear? (using isocalendar under the hood)

I would low confidence vote to align with other libraries — though because I don't know any better — and if anyone has an actual view then I defer to them...

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isocalendar to dt fields 728888328
716137994 https://github.com/pydata/xarray/pull/4534#issuecomment-716137994 https://api.github.com/repos/pydata/xarray/issues/4534 MDEyOklzc3VlQ29tbWVudDcxNjEzNzk5NA== mathause 10194086 2020-10-25T12:12:41Z 2020-10-25T12:12:41Z MEMBER

Do you think we should keep supporting week & weekofyear? (using isocalendar under the hood) 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add isocalendar to dt fields 728888328

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);