issue_comments: 720145456

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4534#issuecomment-720145456 https://api.github.com/repos/pydata/xarray/issues/4534 720145456 MDEyOklzc3VlQ29tbWVudDcyMDE0NTQ1Ng== 10194086 2020-11-01T20:18:58Z 2020-11-01T21:31:04Z MEMBER

Ok, this should work. Two open questions

  1. It's dt.isocalendar().day in pandas but its actually the weekday. I very much prefer dt.isocalendar().weekday. Are we ok with deviating from pandas?
  2. Should we deprecate week and weekofyear as pandas does? It's easier to do dt.week than dt.isocalendar().week. But dt.week might be ambiguous. (I added the deprecation but I am fine either way). TODO: move them to the deprecated api section.
  3. ~Would be good if someone could double-check the :py:attr: in whats-new (should it be :py:meth:?).~ I think this should be correct now.
 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   728888328