home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 719810471

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4534#issuecomment-719810471 https://api.github.com/repos/pydata/xarray/issues/4534 719810471 MDEyOklzc3VlQ29tbWVudDcxOTgxMDQ3MQ== 10194086 2020-10-30T21:34:24Z 2020-10-30T21:50:43Z MEMBER

I think day and year are still available in the pandas implementation though? It's only week that's going

True, I missed that.

I'd be very happy for someone else to take this on...

I hope I understood this correctly & you don't mind me pushing to your branch.

See the code for my suggestion (tests still missing). I think we need to return a Dataset for isocalendar. The way it's done is a bit inefficient (year and day is computed twice) but we avoid a second code-path. I don't have a strong opinion on deprecating time.dt.week or not.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  728888328
Powered by Datasette · Queries took 0.833ms · About: xarray-datasette