issue_comments

Table actions

13 rows where issue = 658938729 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 4

author_association 2

issue 1

  • Linear interp with NaNs in nd indexer · 13 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
681812005 https://github.com/pydata/xarray/pull/4233#issuecomment-681812005 https://api.github.com/repos/pydata/xarray/issues/4233 MDEyOklzc3VlQ29tbWVudDY4MTgxMjAwNQ== mathause 10194086 2020-08-27T08:50:15Z 2020-08-27T08:50:15Z MEMBER

thanks @jenssss I see this is your first PR - welcome to xarray!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Linear interp with NaNs in nd indexer 658938729
679967683 https://github.com/pydata/xarray/pull/4233#issuecomment-679967683 https://api.github.com/repos/pydata/xarray/issues/4233 MDEyOklzc3VlQ29tbWVudDY3OTk2NzY4Mw== mathause 10194086 2020-08-25T11:27:33Z 2020-08-25T11:28:31Z MEMBER

LGTM. I'll merge in a day or two unless someone else has a comment. (#3924)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Linear interp with NaNs in nd indexer 658938729
679911389 https://github.com/pydata/xarray/pull/4233#issuecomment-679911389 https://api.github.com/repos/pydata/xarray/issues/4233 MDEyOklzc3VlQ29tbWVudDY3OTkxMTM4OQ== mathause 10194086 2020-08-25T09:22:27Z 2020-08-25T09:22:27Z MEMBER

Thanks! I have two more suggestions:

Can you add an additional line with python (["2000-01-01T12:00", "2000-01-02T12:00", "NaT"], [0.5, 1.5]), here:

https://github.com/pydata/xarray/blob/8313c3eb7e92c15a82a3ae8ba7dff7d49a37c309/xarray/tests/test_interp.py#L575

to have a test with a missing datetime.

Do you also want to add a note to the docstring, e.g. adding Missing values are skipped. Here:

https://github.com/pydata/xarray/blob/a36d0a1d4657c848dcdd76d0ecb9c783ad464057/xarray/core/dataarray.py#L1425 here: https://github.com/pydata/xarray/blob/a36d0a1d4657c848dcdd76d0ecb9c783ad464057/xarray/core/dataarray.py#L1495

Does it also work for DataSets? Then maybe add to the docstring here:

https://github.com/pydata/xarray/blob/a36d0a1d4657c848dcdd76d0ecb9c783ad464057/xarray/core/dataset.py#L2603

and here:

https://github.com/pydata/xarray/blob/a36d0a1d4657c848dcdd76d0ecb9c783ad464057/xarray/core/dataset.py#L2731

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Linear interp with NaNs in nd indexer 658938729
679502302 https://github.com/pydata/xarray/pull/4233#issuecomment-679502302 https://api.github.com/repos/pydata/xarray/issues/4233 MDEyOklzc3VlQ29tbWVudDY3OTUwMjMwMg== jenssss 37403847 2020-08-25T03:17:42Z 2020-08-25T03:17:42Z CONTRIBUTOR

Okay, I removed the ValueError from my previous commit, so the content of _localize is now basically the same as in https://github.com/pydata/xarray/pull/3924/files#discussion_r407101544

I thought it better to use np.issubdtype(new_x.dtype, np.datetime64) instead of new_x.dtype.kind in "mM" to check for datetime type. It's a bit longer, but I think it makes it more readable since you don't have to look up what dtype.kind is.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Linear interp with NaNs in nd indexer 658938729
679327397 https://github.com/pydata/xarray/pull/4233#issuecomment-679327397 https://api.github.com/repos/pydata/xarray/issues/4233 MDEyOklzc3VlQ29tbWVudDY3OTMyNzM5Nw== mathause 10194086 2020-08-24T19:42:16Z 2020-08-24T19:42:16Z MEMBER

I misremembered the behavior of the old np.min with datetimes - see this comment: https://github.com/pydata/xarray/pull/3924/files#discussion_r407101544

Sorry for sending you down the wrong path. I can have another look tomorrow. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Linear interp with NaNs in nd indexer 658938729
678920617 https://github.com/pydata/xarray/pull/4233#issuecomment-678920617 https://api.github.com/repos/pydata/xarray/issues/4233 MDEyOklzc3VlQ29tbWVudDY3ODkyMDYxNw== mathause 10194086 2020-08-24T05:59:47Z 2020-08-24T05:59:47Z MEMBER

Looks good - if you want to go a step further you can probably do something along the lines of (untested):

python if new_x.dtype in "mM" and LooseVersion(np.__version__) < LooseVersion("1.18") and new_x.isnull().any(): raise ValueError("numpy 1.18 or newer required to use interp with datetime/ timedelta array containing missing values") else: imin = ... np.nanmin(...) imax = ...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Linear interp with NaNs in nd indexer 658938729
678735267 https://github.com/pydata/xarray/pull/4233#issuecomment-678735267 https://api.github.com/repos/pydata/xarray/issues/4233 MDEyOklzc3VlQ29tbWVudDY3ODczNTI2Nw== keewis 14808389 2020-08-23T06:23:32Z 2020-08-23T06:23:32Z MEMBER

perfect, thanks for the fix.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Linear interp with NaNs in nd indexer 658938729
678726416 https://github.com/pydata/xarray/pull/4233#issuecomment-678726416 https://api.github.com/repos/pydata/xarray/issues/4233 MDEyOklzc3VlQ29tbWVudDY3ODcyNjQxNg== jenssss 37403847 2020-08-23T04:04:39Z 2020-08-23T04:04:39Z CONTRIBUTOR

Okay, I think that should do it. How does it look now?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Linear interp with NaNs in nd indexer 658938729
678715788 https://github.com/pydata/xarray/pull/4233#issuecomment-678715788 https://api.github.com/repos/pydata/xarray/issues/4233 MDEyOklzc3VlQ29tbWVudDY3ODcxNTc4OA== jenssss 37403847 2020-08-23T01:05:36Z 2020-08-23T01:05:36Z CONTRIBUTOR

I want to try to fix it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Linear interp with NaNs in nd indexer 658938729
678666093 https://github.com/pydata/xarray/pull/4233#issuecomment-678666093 https://api.github.com/repos/pydata/xarray/issues/4233 MDEyOklzc3VlQ29tbWVudDY3ODY2NjA5Mw== keewis 14808389 2020-08-22T17:06:58Z 2020-08-22T17:06:58Z MEMBER

not your fault, the contributing guide did tell you to do that, and I only updated it a few days ago (not in stable yet). Do you want to try to fix that, or should I do it for you?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Linear interp with NaNs in nd indexer 658938729
678661341 https://github.com/pydata/xarray/pull/4233#issuecomment-678661341 https://api.github.com/repos/pydata/xarray/issues/4233 MDEyOklzc3VlQ29tbWVudDY3ODY2MTM0MQ== jenssss 37403847 2020-08-22T16:28:27Z 2020-08-22T16:28:27Z CONTRIBUTOR

@keewis, sorry I'm still kinda new to Github. Yeah, I did a rebase from upstream/master, and then a pull before pushing back up. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Linear interp with NaNs in nd indexer 658938729
678636782 https://github.com/pydata/xarray/pull/4233#issuecomment-678636782 https://api.github.com/repos/pydata/xarray/issues/4233 MDEyOklzc3VlQ29tbWVudDY3ODYzNjc4Mg== keewis 14808389 2020-08-22T12:47:10Z 2020-08-22T12:47:10Z MEMBER

@jenssss, there's something wrong with the commit history (which makes reviewing pretty hard). Did you by change do git rebase upstream/master followed by a rebase pull?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Linear interp with NaNs in nd indexer 658938729
659908563 https://github.com/pydata/xarray/pull/4233#issuecomment-659908563 https://api.github.com/repos/pydata/xarray/issues/4233 MDEyOklzc3VlQ29tbWVudDY1OTkwODU2Mw== fujiisoup 6815844 2020-07-17T07:02:56Z 2020-07-17T07:02:56Z MEMBER

Thanks, @jenssss for sending a PR. This looks good to me. Could you add a line for this contribution to our whatsnew?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Linear interp with NaNs in nd indexer 658938729

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);