issue_comments: 679911389
This data as json
| html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
|---|---|---|---|---|---|---|---|---|---|---|---|
| https://github.com/pydata/xarray/pull/4233#issuecomment-679911389 | https://api.github.com/repos/pydata/xarray/issues/4233 | 679911389 | MDEyOklzc3VlQ29tbWVudDY3OTkxMTM4OQ== | 10194086 | 2020-08-25T09:22:27Z | 2020-08-25T09:22:27Z | MEMBER | Thanks! I have two more suggestions: Can you add an additional line with
to have a test with a missing datetime. Do you also want to add a note to the docstring, e.g. adding https://github.com/pydata/xarray/blob/a36d0a1d4657c848dcdd76d0ecb9c783ad464057/xarray/core/dataarray.py#L1425 here: https://github.com/pydata/xarray/blob/a36d0a1d4657c848dcdd76d0ecb9c783ad464057/xarray/core/dataarray.py#L1495 Does it also work for DataSets? Then maybe add to the docstring here: and here: |
{
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
} |
658938729 |