issue_comments: 679502302

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4233#issuecomment-679502302 https://api.github.com/repos/pydata/xarray/issues/4233 679502302 MDEyOklzc3VlQ29tbWVudDY3OTUwMjMwMg== 37403847 2020-08-25T03:17:42Z 2020-08-25T03:17:42Z CONTRIBUTOR

Okay, I removed the ValueError from my previous commit, so the content of _localize is now basically the same as in https://github.com/pydata/xarray/pull/3924/files#discussion_r407101544

I thought it better to use np.issubdtype(new_x.dtype, np.datetime64) instead of new_x.dtype.kind in "mM" to check for datetime type. It's a bit longer, but I think it makes it more readable since you don't have to look up what dtype.kind is.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   658938729