issue_comments

Table actions

5 rows where issue = 613546626 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Revise pull request template · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
643947493 https://github.com/pydata/xarray/pull/4039#issuecomment-643947493 https://api.github.com/repos/pydata/xarray/issues/4039 MDEyOklzc3VlQ29tbWVudDY0Mzk0NzQ5Mw== shoyer 1217238 2020-06-15T07:12:11Z 2020-06-15T07:12:11Z MEMBER

OK, revised.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Revise pull request template 613546626
643329618 https://github.com/pydata/xarray/pull/4039#issuecomment-643329618 https://api.github.com/repos/pydata/xarray/issues/4039 MDEyOklzc3VlQ29tbWVudDY0MzMyOTYxOA== dcherian 2448579 2020-06-12T15:17:23Z 2020-06-12T15:17:23Z MEMBER

So maybe we paste that into the whatsnew too, and we're covered?

Seems like this was the consensus at this meeting. So let's add another step to HOW_TO_RELEASE and then merge this?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Revise pull request template 613546626
624967642 https://github.com/pydata/xarray/pull/4039#issuecomment-624967642 https://api.github.com/repos/pydata/xarray/issues/4039 MDEyOklzc3VlQ29tbWVudDYyNDk2NzY0Mg== max-sixty 5635139 2020-05-07T00:55:50Z 2020-05-07T00:57:18Z MEMBER 
* We could update this manually as part of the release process (but this adds one more step for core developers)

Now I think of it, we do this already: https://github.com/pydata/xarray/blame/master/HOW_TO_RELEASE.md#L114

So maybe we paste that into the whatsnew too, and we're covered?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Revise pull request template 613546626
624932391 https://github.com/pydata/xarray/pull/4039#issuecomment-624932391 https://api.github.com/repos/pydata/xarray/issues/4039 MDEyOklzc3VlQ29tbWVudDYyNDkzMjM5MQ== shoyer 1217238 2020-05-06T22:54:14Z 2020-05-06T22:54:14Z MEMBER

I was leaning to "everyone add their name", as it's a way of giving contributors credit, and some visible ownership — even for small changes which might be someone's first PR.

I agree, this is a nice idea.

My goals were to make things simpler for new contributors and also to make whats-new a little bit for readers.

Two ways we might still achieve this:

  • We could still have a section in the release notes for each version for contributors to add their name
  • We could update this manually as part of the release process (but this adds one more step for core developers)
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Revise pull request template 613546626
624839831 https://github.com/pydata/xarray/pull/4039#issuecomment-624839831 https://api.github.com/repos/pydata/xarray/issues/4039 MDEyOklzc3VlQ29tbWVudDYyNDgzOTgzMQ== max-sixty 5635139 2020-05-06T19:19:10Z 2020-05-06T19:19:10Z MEMBER

I think that's reasonable

I was leaning to "everyone add their name", as it's a way of giving contributors credit, and some visible ownership — even for small changes which might be someone's first PR.

But I agree that's not always consistent with making the whatsnew better for readers.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Revise pull request template 613546626

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);