issues: 613546626

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
613546626 MDExOlB1bGxSZXF1ZXN0NDE0MjgwMDEz 4039 Revise pull request template 1217238 closed 0     5 2020-05-06T19:08:19Z 2020-06-18T05:45:11Z 2020-06-18T05:45:10Z MEMBER   0 pydata/xarray/pulls/4039

See below for the new language, to clarify that documentation is only necessary for "user visible changes."

I added "including notable bug fixes" to indicate that minor bug fixes may not be worth noting (I was thinking of test-suite only fixes in this category) but perhaps that is too confusing.

cc @pydata/xarray for opinions!

  • [ ] Closes #xxxx
  • [ ] Tests added
  • [ ] Passes isort -rc . && black . && mypy . && flake8
  • [ ] Fully documented, including whats-new.rst for user visible changes (including notable bug fixes) and api.rst for new API
 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/4039/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables