issue_comments: 624932391

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/4039#issuecomment-624932391 https://api.github.com/repos/pydata/xarray/issues/4039 624932391 MDEyOklzc3VlQ29tbWVudDYyNDkzMjM5MQ== 1217238 2020-05-06T22:54:14Z 2020-05-06T22:54:14Z MEMBER

I was leaning to "everyone add their name", as it's a way of giving contributors credit, and some visible ownership — even for small changes which might be someone's first PR.

I agree, this is a nice idea.

My goals were to make things simpler for new contributors and also to make whats-new a little bit for readers.

Two ways we might still achieve this:

  • We could still have a section in the release notes for each version for contributors to add their name
  • We could update this manually as part of the release process (but this adds one more step for core developers)
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   613546626