issue_comments

Table actions

3 rows where issue = 577425749 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 3 ✖

issue 1

  • provide a error summary for assert_allclose · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
634868914 https://github.com/pydata/xarray/pull/3847#issuecomment-634868914 https://api.github.com/repos/pydata/xarray/issues/3847 MDEyOklzc3VlQ29tbWVudDYzNDg2ODkxNA== shoyer 1217238 2020-05-27T18:50:12Z 2020-05-27T18:50:12Z MEMBER

I'm confused, I thought that xr.testing.assert_allclose explicitly supported duck arrays (it calls duck_array_ops.allclose_or_equiv).

Right, it explicitly supports duck arrays -- by always converting them into NumPy!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   provide a error summary for assert_allclose 577425749
634855041 https://github.com/pydata/xarray/pull/3847#issuecomment-634855041 https://api.github.com/repos/pydata/xarray/issues/3847 MDEyOklzc3VlQ29tbWVudDYzNDg1NTA0MQ== shoyer 1217238 2020-05-27T18:25:40Z 2020-05-27T18:25:40Z MEMBER

So it seems that assert_allclose never worked with dask but always converted to numpy. Would it make sense to investigate further, or is it better to just wait until we can merge this?

This was intentional, I think. np.testing.assert_allclose() doesn't support dispatching -- it always converts into NumPy arrays. I'm not sure that assert_allclose would even be well defined on dask arrays otherwise, because it doesn't have any output (it only raises an error).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   provide a error summary for assert_allclose 577425749
628083718 https://github.com/pydata/xarray/pull/3847#issuecomment-628083718 https://api.github.com/repos/pydata/xarray/issues/3847 MDEyOklzc3VlQ29tbWVudDYyODA4MzcxOA== shoyer 1217238 2020-05-13T15:55:52Z 2020-05-13T15:55:52Z MEMBER

It looks like there might be some sort of issue with dask's numpy compatibility layer? e.g., in np.allclose?

These fallbacks are catching quite a few errors....

One idea would be to try plumbing this logic into np.testing.assert_allclose (which doesn't do dispatching) rather than np.allclose. The former comes pre-packaged with better error messages, which might be handy.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   provide a error summary for assert_allclose 577425749

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);