issue_comments: 634855041

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3847#issuecomment-634855041 https://api.github.com/repos/pydata/xarray/issues/3847 634855041 MDEyOklzc3VlQ29tbWVudDYzNDg1NTA0MQ== 1217238 2020-05-27T18:25:40Z 2020-05-27T18:25:40Z MEMBER

So it seems that assert_allclose never worked with dask but always converted to numpy. Would it make sense to investigate further, or is it better to just wait until we can merge this?

This was intentional, I think. np.testing.assert_allclose() doesn't support dispatching -- it always converts into NumPy arrays. I'm not sure that assert_allclose would even be well defined on dask arrays otherwise, because it doesn't have any output (it only raises an error).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   577425749