issues: 577425749

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
577425749 MDExOlB1bGxSZXF1ZXN0Mzg1MjExNzc1 3847 provide a error summary for assert_allclose 14808389 closed 0     27 2020-03-08T01:06:20Z 2020-06-13T17:53:08Z 2020-06-13T17:53:03Z MEMBER   0 pydata/xarray/pulls/3847

right now, unlike assert_identical and assert_equals, assert_allclose simply prints the mismatching data without providing a summary about what failed. This tries to fix that by allowing the compat parameter to formatting.diff_array_repr and formatting.diff_dataset_repr to be a callable and by rewriting assert_allclose to only have one assert statement per type.

  • [x] Closes #3617, closes #1690?
  • [x] Tests added
  • [x] Passes isort -rc . && black . && mypy . && flake8
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API

There are still more tests to write but I would like to get early feedback about this approach vs. adding a "allclose" compat type in addition to the existing "equals" and "identical" to the formatting functions.

 
{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3847/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
     13221727 pull

Links from other tables