issue_comments

Table actions

2 rows where issue = 535703663 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

These facets timed out: author_association

user 1

  • dcherian · 2 ✖

issue 1

  • Feature Request: Efficient rolling with strides · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
851641056 https://github.com/pydata/xarray/issues/3608#issuecomment-851641056 https://api.github.com/repos/pydata/xarray/issues/3608 MDEyOklzc3VlQ29tbWVudDg1MTY0MTA1Ng== dcherian 2448579 2021-05-31T19:09:00Z 2021-05-31T19:09:00Z MEMBER

sliding_window_view is a numpy function (see npcompat.py), so you need not transform to dask.

For reduce I think we just have to pass stride to _construct as in https://github.com/pydata/xarray/issues/3608#issuecomment-811156323 and for bottleneck insert the .isel call (copied from the end of _construct) after the DataArray is constructed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature Request: Efficient rolling with strides 535703663
811156323 https://github.com/pydata/xarray/issues/3608#issuecomment-811156323 https://api.github.com/repos/pydata/xarray/issues/3608 MDEyOklzc3VlQ29tbWVudDgxMTE1NjMyMw== dcherian 2448579 2021-03-31T15:27:47Z 2021-03-31T15:27:47Z MEMBER

No. but this should be really easy to fix.

construct already supports stride.

reduce can easily support stride by passing it on here: https://github.com/pydata/xarray/blob/57a4479fcd3ebc579cf00e0d6bf85007eda44b56/xarray/core/rolling.py#L441-L443

We should also add it to _reduce_method

bottleneck does not support stride so we can only use a .isel call at the end of _bottleneck_reduce https://github.com/pydata/xarray/blob/57a4479fcd3ebc579cf00e0d6bf85007eda44b56/xarray/core/rolling.py#L518

Note: sliding_window_view does not support stride because it's easy to stride after constructing that view (i saw this on some numpy issue)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature Request: Efficient rolling with strides 535703663

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);