home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 811156323

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3608#issuecomment-811156323 https://api.github.com/repos/pydata/xarray/issues/3608 811156323 MDEyOklzc3VlQ29tbWVudDgxMTE1NjMyMw== 2448579 2021-03-31T15:27:47Z 2021-03-31T15:27:47Z MEMBER

No. but this should be really easy to fix.

construct already supports stride.

reduce can easily support stride by passing it on here: https://github.com/pydata/xarray/blob/57a4479fcd3ebc579cf00e0d6bf85007eda44b56/xarray/core/rolling.py#L441-L443

We should also add it to _reduce_method

bottleneck does not support stride so we can only use a .isel call at the end of _bottleneck_reduce https://github.com/pydata/xarray/blob/57a4479fcd3ebc579cf00e0d6bf85007eda44b56/xarray/core/rolling.py#L518

Note: sliding_window_view does not support stride because it's easy to stride after constructing that view (i saw this on some numpy issue)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  535703663
Powered by Datasette · Queries took 0.722ms · About: xarray-datasette