issue_comments

Table actions

5 rows where issue = 534329975 and user = 2448579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: updated_at (date)

user 1

  • dcherian · 5 ✖

issue 1

  • silence sphinx warnings round 3 · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
566640683 https://github.com/pydata/xarray/pull/3602#issuecomment-566640683 https://api.github.com/repos/pydata/xarray/issues/3602 MDEyOklzc3VlQ29tbWVudDU2NjY0MDY4Mw== dcherian 2448579 2019-12-17T16:29:58Z 2019-12-17T16:29:58Z MEMBER

:clap: Welcome to xarray!

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   silence sphinx warnings round 3 534329975
566637976 https://github.com/pydata/xarray/pull/3602#issuecomment-566637976 https://api.github.com/repos/pydata/xarray/issues/3602 MDEyOklzc3VlQ29tbWVudDU2NjYzNzk3Ng== dcherian 2448579 2019-12-17T16:23:48Z 2019-12-17T16:23:48Z MEMBER

:+1: Wanna merge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   silence sphinx warnings round 3 534329975
566596626 https://github.com/pydata/xarray/pull/3602#issuecomment-566596626 https://api.github.com/repos/pydata/xarray/issues/3602 MDEyOklzc3VlQ29tbWVudDU2NjU5NjYyNg== dcherian 2448579 2019-12-17T15:41:20Z 2019-12-17T15:41:20Z MEMBER

A grep over the code tells me that load_store is never used, tested or mentioned (from_store is mentioned but never defined or used): do we still support it?

I guess from_store mentions should be removed; let's open an issue for removing load_store. I don't know the backend code but it'd gone through multiple refactors so things may have been missed.

dump_to_store is mentioned and tested, so we definitely should put it somewhere (even if it is just api-hidden.rst).

Let's stick this in api-hidden.rst

I think you should merge this after making these changes. It's a large step forward. We can revisit once someone comes up with a solution for the injected methods.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   silence sphinx warnings round 3 534329975
565087019 https://github.com/pydata/xarray/pull/3602#issuecomment-565087019 https://api.github.com/repos/pydata/xarray/issues/3602 MDEyOklzc3VlQ29tbWVudDU2NTA4NzAxOQ== dcherian 2448579 2019-12-12T16:43:48Z 2019-12-12T16:43:48Z MEMBER

Is this ready to merge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   silence sphinx warnings round 3 534329975
564600809 https://github.com/pydata/xarray/pull/3602#issuecomment-564600809 https://api.github.com/repos/pydata/xarray/issues/3602 MDEyOklzc3VlQ29tbWVudDU2NDYwMDgwOQ== dcherian 2448579 2019-12-11T15:38:01Z 2019-12-11T15:38:01Z MEMBER

The Data*Coordinates objects are returned by the coords attributes of DataArray and Dataset

Ah! I was wrong. These are public and have public methods that should be documented: see https://xarray.pydata.org/en/stable/data-structures.html#coordinates-methods

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   silence sphinx warnings round 3 534329975

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);