home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 566596626

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3602#issuecomment-566596626 https://api.github.com/repos/pydata/xarray/issues/3602 566596626 MDEyOklzc3VlQ29tbWVudDU2NjU5NjYyNg== 2448579 2019-12-17T15:41:20Z 2019-12-17T15:41:20Z MEMBER

A grep over the code tells me that load_store is never used, tested or mentioned (from_store is mentioned but never defined or used): do we still support it?

I guess from_store mentions should be removed; let's open an issue for removing load_store. I don't know the backend code but it'd gone through multiple refactors so things may have been missed.

dump_to_store is mentioned and tested, so we definitely should put it somewhere (even if it is just api-hidden.rst).

Let's stick this in api-hidden.rst

I think you should merge this after making these changes. It's a large step forward. We can revisit once someone comes up with a solution for the injected methods.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  534329975
Powered by Datasette · Queries took 0.874ms · About: xarray-datasette