issue_comments

Table actions

5 rows where issue = 484778823 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Raise on inplace=True · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
524963950 https://github.com/pydata/xarray/pull/3260#issuecomment-524963950 https://api.github.com/repos/pydata/xarray/issues/3260 MDEyOklzc3VlQ29tbWVudDUyNDk2Mzk1MA== shoyer 1217238 2019-08-26T18:02:36Z 2019-08-26T18:02:36Z MEMBER

Yes, ds.update() should always be inplace.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Raise on inplace=True 484778823
524963547 https://github.com/pydata/xarray/pull/3260#issuecomment-524963547 https://api.github.com/repos/pydata/xarray/issues/3260 MDEyOklzc3VlQ29tbWVudDUyNDk2MzU0Nw== max-sixty 5635139 2019-08-26T18:01:37Z 2019-08-26T18:01:37Z MEMBER

Could we make _check_inplace() entirely non-assigning? e.g., inplace = _check_inplace(inplace) -> _check_inplace(inplace)?

Yes, good idea.

Currently ds.update(inplace=[True|False]) will raise, by default it'll be True, is that OK?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Raise on inplace=True 484778823
524961804 https://github.com/pydata/xarray/pull/3260#issuecomment-524961804 https://api.github.com/repos/pydata/xarray/issues/3260 MDEyOklzc3VlQ29tbWVudDUyNDk2MTgwNA== shoyer 1217238 2019-08-26T17:57:35Z 2019-08-26T17:57:35Z MEMBER

Could we make _check_inplace() entirely non-assigning? e.g., inplace = _check_inplace(inplace) -> _check_inplace(inplace)?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Raise on inplace=True 484778823
524670484 https://github.com/pydata/xarray/pull/3260#issuecomment-524670484 https://api.github.com/repos/pydata/xarray/issues/3260 MDEyOklzc3VlQ29tbWVudDUyNDY3MDQ4NA== max-sixty 5635139 2019-08-25T22:42:49Z 2019-08-25T22:42:49Z MEMBER

All done, unless anyone has thoughts re inplace

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Raise on inplace=True 484778823
524650833 https://github.com/pydata/xarray/pull/3260#issuecomment-524650833 https://api.github.com/repos/pydata/xarray/issues/3260 MDEyOklzc3VlQ29tbWVudDUyNDY1MDgzMw== max-sixty 5635139 2019-08-25T18:00:30Z 2019-08-25T18:00:30Z MEMBER

Great - what are your thoughts on .inplace @shoyer ?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Raise on inplace=True 484778823

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);