home / github / issues

Menu
  • GraphQL API
  • Search all tables

issues: 484778823

This data as json

id node_id number title user state locked assignee milestone comments created_at updated_at closed_at author_association active_lock_reason draft pull_request body reactions performed_via_github_app state_reason repo type
484778823 MDExOlB1bGxSZXF1ZXN0MzEwNTg0MDU5 3260 Raise on inplace=True 5635139 closed 0     5 2019-08-24T04:55:08Z 2019-08-26T18:44:00Z 2019-08-26T18:43:51Z MEMBER   0 pydata/xarray/pulls/3260
  • [x] Removes inplace, and relatedly closes https://github.com/pydata/xarray/issues/1997 (and maybe https://github.com/pydata/xarray/issues/2951)
  • [x] Passes black . && mypy . && flake8
  • [x] Fully documented, including whats-new.rst for all changes and api.rst for new API
  • [x] Remove from doc strings, docs

Do we want to raise an explicit error for another minor release (rather than remove all traces of inplace)? I'd vote +0.5 - it's likely that some people don't check deprecation warnings and this states the problem clearly

What do we want to do re .update (#2951)?

{
    "url": "https://api.github.com/repos/pydata/xarray/issues/3260/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
    13221727 pull

Links from other tables

  • 0 rows from issues_id in issues_labels
  • 5 rows from issue in issue_comments
Powered by Datasette · Queries took 1.863ms · About: xarray-datasette