issue_comments: 524963547

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3260#issuecomment-524963547 https://api.github.com/repos/pydata/xarray/issues/3260 524963547 MDEyOklzc3VlQ29tbWVudDUyNDk2MzU0Nw== 5635139 2019-08-26T18:01:37Z 2019-08-26T18:01:37Z MEMBER

Could we make _check_inplace() entirely non-assigning? e.g., inplace = _check_inplace(inplace) -> _check_inplace(inplace)?

Yes, good idea.

Currently ds.update(inplace=[True|False]) will raise, by default it'll be True, is that OK?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   484778823