issue_comments

Table actions

2 rows where issue = 483280810 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 2 ✖

issue 1

  • ``argmax()`` causes dask to compute · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
523991579 https://github.com/pydata/xarray/issues/3237#issuecomment-523991579 https://api.github.com/repos/pydata/xarray/issues/3237 MDEyOklzc3VlQ29tbWVudDUyMzk5MTU3OQ== shoyer 1217238 2019-08-22T17:03:27Z 2019-08-22T17:03:27Z MEMBER

Thanks for sharing the patch! I dropped into a debugger by adding --pdb to the pytest command, which revealed what is going on here: ```

PDB post_mortem (IO-capturing turned off) >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> /Users/shoyer/dev/xarray/xarray/core/duck_array_ops.py(295)f() -> raise NotImplementedError(msg) (Pdb) values array(['2000-01-01T00:00:00.000000000', '2000-01-02T00:00:00.000000000', '2000-01-03T00:00:00.000000000'], dtype='datetime64[ns]') (Pdb) func <function nanargmax at 0x1156ff730> (Pdb) func(values, axis=axis, **kwargs) *** AttributeError: module 'xarray.core.nputils' has no attribute 'nanargmax' ```

So it looks like nputils doesn't have nanargmax defined. Instead we need to use nanargmax from NumPy.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ``argmax()`` causes dask to compute 483280810
523659811 https://github.com/pydata/xarray/issues/3237#issuecomment-523659811 https://api.github.com/repos/pydata/xarray/issues/3237 MDEyOklzc3VlQ29tbWVudDUyMzY1OTgxMQ== shoyer 1217238 2019-08-21T21:38:26Z 2019-08-21T21:38:26Z MEMBER

Yes, this is definitely a bug -- thanks for clear example to reproduce it!

These helper functions were originally added back in https://github.com/pydata/xarray/pull/1883 to handle object dtype arrays properly.

So it would be nice to fix this for object arrays in dask, but for the much more common non-object dtype arrays we should really just be using dask.array.nnargmax.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   ``argmax()`` causes dask to compute 483280810

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);