issue_comments: 523991579

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/issues/3237#issuecomment-523991579 https://api.github.com/repos/pydata/xarray/issues/3237 523991579 MDEyOklzc3VlQ29tbWVudDUyMzk5MTU3OQ== 1217238 2019-08-22T17:03:27Z 2019-08-22T17:03:27Z MEMBER

Thanks for sharing the patch! I dropped into a debugger by adding --pdb to the pytest command, which revealed what is going on here: ```

PDB post_mortem (IO-capturing turned off) >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> /Users/shoyer/dev/xarray/xarray/core/duck_array_ops.py(295)f() -> raise NotImplementedError(msg) (Pdb) values array(['2000-01-01T00:00:00.000000000', '2000-01-02T00:00:00.000000000', '2000-01-03T00:00:00.000000000'], dtype='datetime64[ns]') (Pdb) func <function nanargmax at 0x1156ff730> (Pdb) func(values, axis=axis, **kwargs) *** AttributeError: module 'xarray.core.nputils' has no attribute 'nanargmax' ```

So it looks like nputils doesn't have nanargmax defined. Instead we need to use nanargmax from NumPy.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   483280810