issue_comments

Table actions

11 rows where issue = 469871658 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

author_association 2

issue 1

  • Black · 11 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
519683957 https://github.com/pydata/xarray/pull/3142#issuecomment-519683957 https://api.github.com/repos/pydata/xarray/issues/3142 MDEyOklzc3VlQ29tbWVudDUxOTY4Mzk1Nw== max-sixty 5635139 2019-08-08T20:55:14Z 2019-08-08T20:55:14Z MEMBER

Please ping here / tag me on the relevant PR with any issues, and I'll help!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Black 469871658
519678389 https://github.com/pydata/xarray/pull/3142#issuecomment-519678389 https://api.github.com/repos/pydata/xarray/issues/3142 MDEyOklzc3VlQ29tbWVudDUxOTY3ODM4OQ== max-sixty 5635139 2019-08-08T20:37:26Z 2019-08-08T20:37:26Z MEMBER

OK - going to hit the button as soon as tests pass.

🙏 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Black 469871658
519627371 https://github.com/pydata/xarray/pull/3142#issuecomment-519627371 https://api.github.com/repos/pydata/xarray/issues/3142 MDEyOklzc3VlQ29tbWVudDUxOTYyNzM3MQ== dcherian 2448579 2019-08-08T18:06:04Z 2019-08-08T18:06:04Z MEMBER

:exclamation: 

{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 1
}
   Black 469871658
519624476 https://github.com/pydata/xarray/pull/3142#issuecomment-519624476 https://api.github.com/repos/pydata/xarray/issues/3142 MDEyOklzc3VlQ29tbWVudDUxOTYyNDQ3Ng== max-sixty 5635139 2019-08-08T17:58:09Z 2019-08-08T17:58:09Z MEMBER

@pydata/xarray this is ready to go!

Any final comments / thoughts / feedback?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Black 469871658
519238589 https://github.com/pydata/xarray/pull/3142#issuecomment-519238589 https://api.github.com/repos/pydata/xarray/issues/3142 MDEyOklzc3VlQ29tbWVudDUxOTIzODU4OQ== max-sixty 5635139 2019-08-07T19:33:04Z 2019-08-07T19:33:04Z MEMBER

On a different note, have you considered adding the pyupgrade and autoflake8 autoformatters?

Nice, I didn't know those. I had use autopep8 before. isort is another I use a lot.

+1, but let's avoid bloating and leave it for a later PR

Yeah - not sure of the balance here. I think the focus should be on easy initial contributions. Consistent formatting is helpful in reading and reviewing code, and eliminating any formatting iterations. Each extra tool's benefit needs to be weighed against the startup cost of another install - unless there's a way of eliminating that (e.g. I've seen some bots add the code changes from GH)

An alternative is to run those additional tools across the whole codebase on occasion, assuming this doesn't create too many merge conflicts.

Interested in others' thoughts... (but probably for another PR)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Black 469871658
519026245 https://github.com/pydata/xarray/pull/3142#issuecomment-519026245 https://api.github.com/repos/pydata/xarray/issues/3142 MDEyOklzc3VlQ29tbWVudDUxOTAyNjI0NQ== crusaderky 6213168 2019-08-07T09:49:17Z 2019-08-07T09:49:17Z MEMBER

I did a manual pass of pyupgrade (#3190), and it looks good. +1, but let's avoid bloating and leave it for a later PR

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Black 469871658
518929174 https://github.com/pydata/xarray/pull/3142#issuecomment-518929174 https://api.github.com/repos/pydata/xarray/issues/3142 MDEyOklzc3VlQ29tbWVudDUxODkyOTE3NA== Zac-HD 12229877 2019-08-07T03:54:03Z 2019-08-07T03:54:03Z CONTRIBUTOR

Sadly if there's a way to automatically fix up merge conflicts I don't know of it 😭. However I'd be happy to help anyone who is having trouble rebasing their open PR.

On a different note, have you considered adding the pyupgrade and autoflake8 autoformatters? They go further than Black in that they do change the AST, but it's a nice way to ensure consistency of style, automatically remove unused imports and variables for flake8, and so on.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Black 469871658
518373612 https://github.com/pydata/xarray/pull/3142#issuecomment-518373612 https://api.github.com/repos/pydata/xarray/issues/3142 MDEyOklzc3VlQ29tbWVudDUxODM3MzYxMg== shoyer 1217238 2019-08-05T19:48:44Z 2019-08-05T19:48:44Z MEMBER

Let's do it after merging #2277

On Mon, Aug 5, 2019 at 11:17 AM Maximilian Roos notifications@github.com wrote:

What are people's thoughts on doing this now? There are a few big merges happening atm, so could do this after those.

I tested the approach above https://github.com/pydata/xarray/pull/3142#issuecomment-514325568 and it worked well. I don't have any more external validation than my test though. If anyone has experience here, please let us know.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/3142?email_source=notifications&email_token=AAJJFVVE7WXUFCD4PTPJ3W3QDBVCVA5CNFSM4IE5PZH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3SUOXY#issuecomment-518342495, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJJFVS5ZVHUHZKHTRBZTJTQDBVCVANCNFSM4IE5PZHQ . 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Black 469871658
518342495 https://github.com/pydata/xarray/pull/3142#issuecomment-518342495 https://api.github.com/repos/pydata/xarray/issues/3142 MDEyOklzc3VlQ29tbWVudDUxODM0MjQ5NQ== max-sixty 5635139 2019-08-05T18:17:12Z 2019-08-05T18:17:12Z MEMBER

What are people's thoughts on doing this now? There are a few big merges happening atm, so could do this after those.

I tested the approach above and it worked well. I don't have any more external validation than my test though. If anyone has experience here, please let us know.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Black 469871658
514325568 https://github.com/pydata/xarray/pull/3142#issuecomment-514325568 https://api.github.com/repos/pydata/xarray/issues/3142 MDEyOklzc3VlQ29tbWVudDUxNDMyNTU2OA== max-sixty 5635139 2019-07-23T18:19:46Z 2019-07-23T18:19:46Z MEMBER

I think we can suggest something like this to existing PRs to eliminate manual conflicts, and I'm attempting to find something more official. Let me know if anyone knows of something:

  • Merge master prior to the black commit (any conflicts are real conflicts and require resolving)
  • Apply black . to this branch
  • Merge master at the black commit, resolving in favor of our changes: git merge [black-commit] -X ours
  • Merge current master (any conflicts here are real and again require resolving) 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Black 469871658
512970882 https://github.com/pydata/xarray/pull/3142#issuecomment-512970882 https://api.github.com/repos/pydata/xarray/issues/3142 MDEyOklzc3VlQ29tbWVudDUxMjk3MDg4Mg== max-sixty 5635139 2019-07-18T20:16:27Z 2019-07-18T20:16:27Z MEMBER

FYI, unfortunately pep8speaks doesn't yet support black

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Black 469871658

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);