issue_comments: 519238589

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3142#issuecomment-519238589 https://api.github.com/repos/pydata/xarray/issues/3142 519238589 MDEyOklzc3VlQ29tbWVudDUxOTIzODU4OQ== 5635139 2019-08-07T19:33:04Z 2019-08-07T19:33:04Z MEMBER

On a different note, have you considered adding the pyupgrade and autoflake8 autoformatters?

Nice, I didn't know those. I had use autopep8 before. isort is another I use a lot.

+1, but let's avoid bloating and leave it for a later PR

Yeah - not sure of the balance here. I think the focus should be on easy initial contributions. Consistent formatting is helpful in reading and reviewing code, and eliminating any formatting iterations. Each extra tool's benefit needs to be weighed against the startup cost of another install - unless there's a way of eliminating that (e.g. I've seen some bots add the code changes from GH)

An alternative is to run those additional tools across the whole codebase on occasion, assuming this doesn't create too many merge conflicts.

Interested in others' thoughts... (but probably for another PR)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   469871658