issue_comments: 518373612

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3142#issuecomment-518373612 https://api.github.com/repos/pydata/xarray/issues/3142 518373612 MDEyOklzc3VlQ29tbWVudDUxODM3MzYxMg== 1217238 2019-08-05T19:48:44Z 2019-08-05T19:48:44Z MEMBER

Let's do it after merging #2277

On Mon, Aug 5, 2019 at 11:17 AM Maximilian Roos notifications@github.com wrote:

What are people's thoughts on doing this now? There are a few big merges happening atm, so could do this after those.

I tested the approach above https://github.com/pydata/xarray/pull/3142#issuecomment-514325568 and it worked well. I don't have any more external validation than my test though. If anyone has experience here, please let us know.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/3142?email_source=notifications&email_token=AAJJFVVE7WXUFCD4PTPJ3W3QDBVCVA5CNFSM4IE5PZH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3SUOXY#issuecomment-518342495, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJJFVS5ZVHUHZKHTRBZTJTQDBVCVANCNFSM4IE5PZHQ . 

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   469871658