I was wondering why the checksum kept failing. I'm glad that it's fixed now.

On Fri, Aug 23, 2019 at 9:11 AM Deepak Cherian notifications@github.com wrote:

It looks awesome!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_pydata_xarray_pull_3116-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAAT2YFSAUGSDJVR3SMCFONTQGAD2BA5CNFSM4IDCS2Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5AU3WI-23issuecomment-2D524373465&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=jNHhw3-wczG-R1InYBWYHh1uySwOv2LvBhXHalRpLiM&s=4IE-mPoo-xIwygm2i5CE6JBKiZjK9AH9Acgx5swXjiM&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAT2YFQJTIUV6SXZI5H4EMLQGAD2BANCNFSM4IDCS2QQ&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=jNHhw3-wczG-R1InYBWYHh1uySwOv2LvBhXHalRpLiM&s=x5ZRvEPW7XBD1pfrzhF1Cszg_rgQ-qAyEysBTPrfTDY&e= .

-- Prof. Rob Hetland Texas A&M Univ. – Dept. of Oceanography http://pong.tamu.edu/~rob

It looks awesome!

I finally got the page to build and it looks great! http://xarray.pydata.org/en/scipy19-docs/examples/ROMS_ocean_model.html

There was an issue with the ROMS MD5 checksum which I fixed in https://github.com/pydata/xarray-data/pull/17. The checksums .md5 files cannot have newlines at the end.

I am returning to this after some vacation. Thanks so much @hetland for this great example!

The test failures are not related to this PR. I see only three things that need to be done to get this ready to merge.

• [x] Add a short introductory paragraph at the very top of the notebook with some very general backgroud. Remember we have users from tons of different fields (e.g. finance, bioinformatics); they will have no idea what ROMS stands for or even what an ocean model is. We need a few sentences to introduce this example and explain what it shows (primarily how to visualize data that has irregular / derived coordinate geometry)
• [x] Remove or resolve the commented-out code in the example.
• [x] Add credit to @hetland in whats-new.rst

Thanks for this @hetland! I'm going to merge now!

Codecov Report

Merging #3116 into scipy19-docs will increase coverage by <.01%. The diff coverage is 100%.

```diff @@ Coverage Diff @@

scipy19-docs #3116 +/-

================================================ + Coverage 95.99% 95.99% +<.01%
================================================ Files 63 63
Lines 12796 12799 +3
================================================ + Hits 12284 12287 +3
Misses 512 512 ```

Hopefully these changes are all done now. I added my credit to 'Enhancements' instead of 'New functions/methods'; hope I guessed right. I didn't see any other examples of notebooks added.

On Fri, Aug 2, 2019 at 5:24 AM Ryan Abernathey notifications@github.com wrote:

I am returning to this after some vacation. Thanks so much @hetland https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_hetland&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=6OwOv4lp3GGGKs1J1l2TyWR-fMyQK6bqwmVZSz5B_0A&s=9wZu4m94pOYewRGrzb8Hm4LFjT-B1u5RSGvnkDmWq5s&e= for this great example!

The test failures are not related to this PR. I see only three things that need to be done to get this ready to merge.

• Add a short introductory paragraph at the very top of the notebook with some very general backgroud. Remember we have users from tons of different fields (e.g. finance, bioinformatics); they will have no idea what ROMS stands for or even what an ocean model is. We need a few sentences to introduce this example and explain what it shows (primarily how to visualize data that has irregular / derived coordinate geometry)
• Remove or resolve the commented-out code in the example.
• Add credit to @hetland https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_hetland&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=6OwOv4lp3GGGKs1J1l2TyWR-fMyQK6bqwmVZSz5B_0A&s=9wZu4m94pOYewRGrzb8Hm4LFjT-B1u5RSGvnkDmWq5s&e= in whats-new.rst

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_pydata_xarray_pull_3116-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAAT2YFROYNHJ7S2DREKVOC3QCQDPRA5CNFSM4IDCS2Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3NLNPA-23issuecomment-2D517650108&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=6OwOv4lp3GGGKs1J1l2TyWR-fMyQK6bqwmVZSz5B_0A&s=t-z2yW4pb_z0ymnYO-k9w-VH5rMcQ050xTkIM9AKC5U&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAT2YFU4QP7IADADC2NTS3DQCQDPRANCNFSM4IDCS2QQ&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=6OwOv4lp3GGGKs1J1l2TyWR-fMyQK6bqwmVZSz5B_0A&s=8rqgwomPBkre8gH1dTw4pH2u67J2wpVX7h_2Eh80mCE&e= .

-- Prof. Rob Hetland Texas A&M Univ. – Dept. of Oceanography http://pong.tamu.edu/~rob

OK, I closed the other pull request, and updated this branch.

I just saw the new PR (#3134). You don't need to start a new PR unless something is truly broken here. You can just keep pushing to this one.

You have to rebase your feature branch on the upstream/scipy19-docs branch in order to get #3121 to work locally. git fetch upstream git rebase upstream/scipy19-docs

Can you post the error and stack trace?

I'm having a hard time getting the docs to compile, they fail when loading the ROMS_example.nc file, though I switched to xr.tutorial.open_dataset('ROMS_example.nc'). Is there something else I need to do? I pushed a revised version.

I'll try to get this done very soon.

On Sun, Jul 14, 2019 at 8:33 PM Ryan Abernathey notifications@github.com wrote:

@hetland https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_hetland&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=iscthtGvDpXaFqvgH9LT53ecbC3ot7AaAZ-m0KOXKE8&s=hdRQyVYJ5Li194ZIzAWhJ0SsneZ15DdjqOya-Uegoo8&e= - thanks so much for this! Now that pydata/xarray-data#13 https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_pydata_xarray-2Ddata_pull_13&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=iscthtGvDpXaFqvgH9LT53ecbC3ot7AaAZ-m0KOXKE8&s=8HH7PmBIx0_3Xe10MPEPiXoT0X_6Pj--82mnkmSXS8w&e= has been merged, can you try to update your example to use the xr.tutorial.open_dataset('ROMS_example.nc') function?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_pydata_xarray_pull_3116-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAAT2YFXWQ23YSBUMI4YKYUDP7PHW7A5CNFSM4IDCS2Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZ4RU2Y-23issuecomment-2D511253099&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=iscthtGvDpXaFqvgH9LT53ecbC3ot7AaAZ-m0KOXKE8&s=ArFBmSuyA9yQqzaU4k0HRy5Ty4Fsn3lR8By69c4kjjs&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAT2YFUQZR7KG4FCGEAB2PDP7PHW7ANCNFSM4IDCS2QQ&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=iscthtGvDpXaFqvgH9LT53ecbC3ot7AaAZ-m0KOXKE8&s=SzNZLx3vqSjXyP508p1VXkBQ9WFnNIWR7JEjMTMHA0w&e= .

-- Prof. Rob Hetland Texas A&M Univ. – Dept. of Oceanography http://pong.tamu.edu/~rob

@hetland - thanks so much for this! Now that https://github.com/pydata/xarray-data/pull/13 has been merged, can you try to update your example to use the xr.tutorial.open_dataset('ROMS_example.nc') function?