home / github / issue_comments

Menu
  • GraphQL API
  • Search all tables

issue_comments: 517650108

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3116#issuecomment-517650108 https://api.github.com/repos/pydata/xarray/issues/3116 517650108 MDEyOklzc3VlQ29tbWVudDUxNzY1MDEwOA== 1197350 2019-08-02T10:24:50Z 2019-08-23T14:44:01Z MEMBER

I am returning to this after some vacation. Thanks so much @hetland for this great example!

The test failures are not related to this PR. I see only three things that need to be done to get this ready to merge.

  • [x] Add a short introductory paragraph at the very top of the notebook with some very general backgroud. Remember we have users from tons of different fields (e.g. finance, bioinformatics); they will have no idea what ROMS stands for or even what an ocean model is. We need a few sentences to introduce this example and explain what it shows (primarily how to visualize data that has irregular / derived coordinate geometry)
  • [x] Remove or resolve the commented-out code in the example.
  • [x] Add credit to @hetland in whats-new.rst
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  467768201
Powered by Datasette · Queries took 80.344ms · About: xarray-datasette