issue_comments: 517819281

This data as json

html_url	issue_url	id	node_id	user	created_at	updated_at	author_association	body	reactions	performed_via_github_app	issue
https://github.com/pydata/xarray/pull/3116#issuecomment-517819281	https://api.github.com/repos/pydata/xarray/issues/3116	517819281	MDEyOklzc3VlQ29tbWVudDUxNzgxOTI4MQ==	2599958	2019-08-02T19:32:34Z	2019-08-02T19:32:34Z	NONE	Hopefully these changes are all done now. I added my credit to 'Enhancements' instead of 'New functions/methods'; hope I guessed right. I didn't see any other examples of notebooks added. On Fri, Aug 2, 2019 at 5:24 AM Ryan Abernathey notifications@github.com wrote: I am returning to this after some vacation. Thanks so much @hetland https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_hetland&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=6OwOv4lp3GGGKs1J1l2TyWR-fMyQK6bqwmVZSz5B_0A&s=9wZu4m94pOYewRGrzb8Hm4LFjT-B1u5RSGvnkDmWq5s&e= for this great example! The test failures are not related to this PR. I see only three things that need to be done to get this ready to merge. Add a short introductory paragraph at the very top of the notebook with some very general backgroud. Remember we have users from tons of different fields (e.g. finance, bioinformatics); they will have no idea what ROMS stands for or even what an ocean model is. We need a few sentences to introduce this example and explain what it shows (primarily how to visualize data that has irregular / derived coordinate geometry) Remove or resolve the commented-out code in the example. Add credit to @hetland https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_hetland&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=6OwOv4lp3GGGKs1J1l2TyWR-fMyQK6bqwmVZSz5B_0A&s=9wZu4m94pOYewRGrzb8Hm4LFjT-B1u5RSGvnkDmWq5s&e= in whats-new.rst — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_pydata_xarray_pull_3116-3Femail-5Fsource-3Dnotifications-26email-5Ftoken-3DAAT2YFROYNHJ7S2DREKVOC3QCQDPRA5CNFSM4IDCS2Q2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3NLNPA-23issuecomment-2D517650108&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=6OwOv4lp3GGGKs1J1l2TyWR-fMyQK6bqwmVZSz5B_0A&s=t-z2yW4pb_z0ymnYO-k9w-VH5rMcQ050xTkIM9AKC5U&e=, or mute the thread https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AAT2YFU4QP7IADADC2NTS3DQCQDPRANCNFSM4IDCS2QQ&d=DwMCaQ&c=u6LDEWzohnDQ01ySGnxMzg&r=T-gqCqhnaasy1XvN-p7wEw&m=6OwOv4lp3GGGKs1J1l2TyWR-fMyQK6bqwmVZSz5B_0A&s=8rqgwomPBkre8gH1dTw4pH2u67J2wpVX7h_2Eh80mCE&e= . -- Prof. Rob Hetland Texas A&M Univ. – Dept. of Oceanography http://pong.tamu.edu/~rob	{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }		467768201