issue_comments

Table actions

4 rows where issue = 460680578 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • max-sixty · 4 ✖

issue 1

  • Add rename_vars and rename_dims · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
508025994 https://github.com/pydata/xarray/pull/3045#issuecomment-508025994 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwODAyNTk5NA== max-sixty 5635139 2019-07-03T09:53:54Z 2019-07-03T09:53:54Z MEMBER

Thanks @jukent! We're happy to have you as a contributor!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578
507532924 https://github.com/pydata/xarray/pull/3045#issuecomment-507532924 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNzUzMjkyNA== max-sixty 5635139 2019-07-02T06:07:56Z 2019-07-02T06:07:56Z MEMBER

The code looks great now, nice work @jukent - very succinct

If we can add that small test that @shoyer references (can do it in one of the existing test, just two lines), and potentially there's a duplication in the whatsnew.

(I'm on vacation so don't wait for me to merge)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578
505998060 https://github.com/pydata/xarray/pull/3045#issuecomment-505998060 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNTk5ODA2MA== max-sixty 5635139 2019-06-26T18:43:08Z 2019-06-26T18:43:08Z MEMBER

FYI tests are failing with E NameError: name '_rename_var_dims_helper' is not defined: https://travis-ci.org/pydata/xarray/jobs/550940568

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578
505656004 https://github.com/pydata/xarray/pull/3045#issuecomment-505656004 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNTY1NjAwNA== max-sixty 5635139 2019-06-25T23:12:36Z 2019-06-25T23:12:36Z MEMBER

FYI the failure in appveyor is unrelated and can be ignored

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);