home / github / issue_comments

Menu
  • Search all tables
  • GraphQL API

issue_comments: 507532924

This data as json

html_url issue_url id node_id user created_at updated_at author_association body reactions performed_via_github_app issue
https://github.com/pydata/xarray/pull/3045#issuecomment-507532924 https://api.github.com/repos/pydata/xarray/issues/3045 507532924 MDEyOklzc3VlQ29tbWVudDUwNzUzMjkyNA== 5635139 2019-07-02T06:07:56Z 2019-07-02T06:07:56Z MEMBER

The code looks great now, nice work @jukent - very succinct

If we can add that small test that @shoyer references (can do it in one of the existing test, just two lines), and potentially there's a duplication in the whatsnew.

(I'm on vacation so don't wait for me to merge)

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  460680578
Powered by Datasette · Queries took 157.752ms · About: xarray-datasette