issue_comments

Table actions

17 rows where issue = 460680578 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at, reactions, created_at (date), updated_at (date)

author_association 3

issue 1

  • Add rename_vars and rename_dims · 17 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
508025994 https://github.com/pydata/xarray/pull/3045#issuecomment-508025994 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwODAyNTk5NA== max-sixty 5635139 2019-07-03T09:53:54Z 2019-07-03T09:53:54Z MEMBER

Thanks @jukent! We're happy to have you as a contributor!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578
507831204 https://github.com/pydata/xarray/pull/3045#issuecomment-507831204 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNzgzMTIwNA== shoyer 1217238 2019-07-02T20:25:02Z 2019-07-02T20:25:02Z MEMBER

thanks @jukent !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578
505651366 https://github.com/pydata/xarray/pull/3045#issuecomment-505651366 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNTY1MTM2Ng== pep8speaks 24736507 2019-06-25T22:50:51Z 2019-07-02T18:28:57Z NONE

Hello @jukent! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2019-07-02 18:28:57 UTC
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578
507436417 https://github.com/pydata/xarray/pull/3045#issuecomment-507436417 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNzQzNjQxNw== codecov[bot] 22429695 2019-07-01T21:41:52Z 2019-07-02T18:28:51Z NONE

Codecov Report

Merging #3045 into master will increase coverage by 1.01%. The diff coverage is 94.11%.

```diff @@ Coverage Diff @@

master #3045 +/-

========================================== + Coverage 93.78% 94.79% +1.01%
========================================== Files 68 67 -1
Lines 13156 12892 -264
========================================== - Hits 12338 12221 -117
+ Misses 818 671 -147 ```

| Impacted Files | Coverage Δ | | |---|---|---| | xarray/core/dataset.py | 96.14% <94.11%> (-0.1%) | :arrow_down: | | xarray/_version.py | | |

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0aeee7f...b3232ad. Read the comment docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578
507791624 https://github.com/pydata/xarray/pull/3045#issuecomment-507791624 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNzc5MTYyNA== shoyer 1217238 2019-07-02T18:22:11Z 2019-07-02T18:22:11Z MEMBER

pep8speaks has a few minor style complaints to fix: https://github.com/pydata/xarray/pull/3045#issuecomment-505651366

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578
507773567 https://github.com/pydata/xarray/pull/3045#issuecomment-507773567 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNzc3MzU2Nw== jukent 46687291 2019-07-02T17:30:59Z 2019-07-02T17:30:59Z CONTRIBUTOR

Added those tests for for the raised Value Error.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578
507532924 https://github.com/pydata/xarray/pull/3045#issuecomment-507532924 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNzUzMjkyNA== max-sixty 5635139 2019-07-02T06:07:56Z 2019-07-02T06:07:56Z MEMBER

The code looks great now, nice work @jukent - very succinct

If we can add that small test that @shoyer references (can do it in one of the existing test, just two lines), and potentially there's a duplication in the whatsnew.

(I'm on vacation so don't wait for me to merge)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578
507487820 https://github.com/pydata/xarray/pull/3045#issuecomment-507487820 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNzQ4NzgyMA== shoyer 1217238 2019-07-02T01:59:11Z 2019-07-02T01:59:11Z MEMBER

Looking at the coverage report from codecov above, it looks like the lines where you raise ValueError for non-existent keys currently don't have any test coverage. Please add unit tests that verify the right error is raised, i.e., with pytest.raises.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578
507442274 https://github.com/pydata/xarray/pull/3045#issuecomment-507442274 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNzQ0MjI3NA== dcherian 2448579 2019-07-01T22:03:23Z 2019-07-01T22:03:23Z MEMBER

OK fixed whats-new. Sorry it gets a little confusing if there's been a release in the meantime.

This looks good to me. @max-sixty check once more and merge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578
507350527 https://github.com/pydata/xarray/pull/3045#issuecomment-507350527 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNzM1MDUyNw== jukent 46687291 2019-07-01T17:14:08Z 2019-07-01T17:14:08Z CONTRIBUTOR

Checks could be more complicated, but I think this is ready to merge!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578
506070868 https://github.com/pydata/xarray/pull/3045#issuecomment-506070868 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNjA3MDg2OA== jukent 46687291 2019-06-26T22:39:31Z 2019-06-26T22:39:31Z CONTRIBUTOR

I would definitely recommend reading through our contributor's guide on how to setup a local environment for testing your code: http://xarray.pydata.org/en/stable/contributing.html

It is much easier to fix issues when you run tests locally rather than waiting on continuous integration tests (Travis-CI) to tell you that things are broken.

Thank you was just needing to look into this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578
506055084 https://github.com/pydata/xarray/pull/3045#issuecomment-506055084 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNjA1NTA4NA== shoyer 1217238 2019-06-26T21:38:17Z 2019-06-26T21:38:17Z MEMBER

I would definitely recommend reading through our contributor's guide on how to setup a local environment for testing your code: http://xarray.pydata.org/en/stable/contributing.html

It is much easier to fix issues when you run tests locally rather than waiting on continuous integration tests (Travis-CI) to tell you that things are broken.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578
506009244 https://github.com/pydata/xarray/pull/3045#issuecomment-506009244 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNjAwOTI0NA== jukent 46687291 2019-06-26T19:17:14Z 2019-06-26T19:17:14Z CONTRIBUTOR

FYI tests are failing with E NameError: name '_rename_var_dims_helper' is not defined: https://travis-ci.org/pydata/xarray/jobs/550940568

Huh not sure why that is. I can remove that function and see if it works then.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578
505998060 https://github.com/pydata/xarray/pull/3045#issuecomment-505998060 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNTk5ODA2MA== max-sixty 5635139 2019-06-26T18:43:08Z 2019-06-26T18:43:08Z MEMBER

FYI tests are failing with E NameError: name '_rename_var_dims_helper' is not defined: https://travis-ci.org/pydata/xarray/jobs/550940568

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578
505980190 https://github.com/pydata/xarray/pull/3045#issuecomment-505980190 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNTk4MDE5MA== dcherian 2448579 2019-06-26T17:54:37Z 2019-06-26T17:54:37Z MEMBER

@jukent You should also give yourself credit in whats-new.rst and add stuff to api.rst. I also see that you're a first-time contributor. Welcome! We really appreciate your efforts.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578
505656004 https://github.com/pydata/xarray/pull/3045#issuecomment-505656004 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNTY1NjAwNA== max-sixty 5635139 2019-06-25T23:12:36Z 2019-06-25T23:12:36Z MEMBER

FYI the failure in appveyor is unrelated and can be ignored

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578
505651365 https://github.com/pydata/xarray/pull/3045#issuecomment-505651365 https://api.github.com/repos/pydata/xarray/issues/3045 MDEyOklzc3VlQ29tbWVudDUwNTY1MTM2NQ== jukent 46687291 2019-06-25T22:50:51Z 2019-06-25T22:50:51Z CONTRIBUTOR

I uninstalled the bot that automatically closed the pull request #3042 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add rename_vars and rename_dims 460680578

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);