issue_comments

Table actions

7 rows where issue = 44718119 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

author_association 2

issue 1

  • Modular encodings (rebased) · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
58765213 https://github.com/pydata/xarray/pull/245#issuecomment-58765213 https://api.github.com/repos/pydata/xarray/issues/245 MDEyOklzc3VlQ29tbWVudDU4NzY1MjEz shoyer 1217238 2014-10-11T21:31:20Z 2014-10-11T21:31:20Z MEMBER

Merged, so I can do some more encodings work on top of this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Modular encodings (rebased) 44718119
58739982 https://github.com/pydata/xarray/pull/245#issuecomment-58739982 https://api.github.com/repos/pydata/xarray/issues/245 MDEyOklzc3VlQ29tbWVudDU4NzM5OTgy shoyer 1217238 2014-10-11T06:29:23Z 2014-10-11T06:29:23Z MEMBER

@akleeman I went ahead and pushed fixes for the failing tests. Feel free to merge if when you're ready.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Modular encodings (rebased) 44718119
58557716 https://github.com/pydata/xarray/pull/245#issuecomment-58557716 https://api.github.com/repos/pydata/xarray/issues/245 MDEyOklzc3VlQ29tbWVudDU4NTU3NzE2 shoyer 1217238 2014-10-09T18:45:08Z 2014-10-09T18:45:08Z MEMBER

should be good to go once you get all the tests passing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Modular encodings (rebased) 44718119
58453834 https://github.com/pydata/xarray/pull/245#issuecomment-58453834 https://api.github.com/repos/pydata/xarray/issues/245 MDEyOklzc3VlQ29tbWVudDU4NDUzODM0 shoyer 1217238 2014-10-09T01:53:38Z 2014-10-09T01:53:38Z MEMBER

K, fine by me.

On Wed, Oct 8, 2014 at 6:37 PM, akleeman notifications@github.com wrote:

re: using accessors such as get_variables.

To be fair, this pull request didn't really switch the behavior, it was already very similar but with different names (store_variables, open_store_variable) that were now changed to get_variables etc. I chose to continue with getters and setters because it makes it fairly clear what needs to be implemented to make a new DataStore, and allows for some post processing such as _decode_variable_name and encoding/decoding. Its not entirely clear to me how that would fit into a properties based approach so sounds like a good follow up pull request to me.

Reply to this email directly or view it on GitHub: https://github.com/xray/xray/pull/245#issuecomment-58452925

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Modular encodings (rebased) 44718119
58452925 https://github.com/pydata/xarray/pull/245#issuecomment-58452925 https://api.github.com/repos/pydata/xarray/issues/245 MDEyOklzc3VlQ29tbWVudDU4NDUyOTI1 akleeman 514053 2014-10-09T01:37:40Z 2014-10-09T01:37:40Z CONTRIBUTOR

re: using accessors such as get_variables.

To be fair, this pull request didn't really switch the behavior, it was already very similar but with different names (store_variables, open_store_variable) that were now changed to get_variables etc. I chose to continue with getters and setters because it makes it fairly clear what needs to be implemented to make a new DataStore, and allows for some post processing such as _decode_variable_name and encoding/decoding. Its not entirely clear to me how that would fit into a properties based approach so sounds like a good follow up pull request to me.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Modular encodings (rebased) 44718119
58424403 https://github.com/pydata/xarray/pull/245#issuecomment-58424403 https://api.github.com/repos/pydata/xarray/issues/245 MDEyOklzc3VlQ29tbWVudDU4NDI0NDAz shoyer 1217238 2014-10-08T20:43:49Z 2014-10-08T20:43:49Z MEMBER

Is there a reason you switched to using accessors (e.g., get_variables) instead of properties? Properties feel a little more pythonic to me. I like the idea of making property classes (e.g., DataStoreVariables) that abstract away the set_variable nonsense behind a dictionary like interface. I can submit a patch to add that, if you like.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Modular encodings (rebased) 44718119
57926297 https://github.com/pydata/xarray/pull/245#issuecomment-57926297 https://api.github.com/repos/pydata/xarray/issues/245 MDEyOklzc3VlQ29tbWVudDU3OTI2Mjk3 shoyer 1217238 2014-10-05T04:24:42Z 2014-10-05T04:24:42Z MEMBER

closing this for now until the discussion in #175 is resolved.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Modular encodings (rebased) 44718119

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);