issue_comments: 58452925
This data as json
html_url | issue_url | id | node_id | user | created_at | updated_at | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
https://github.com/pydata/xarray/pull/245#issuecomment-58452925 | https://api.github.com/repos/pydata/xarray/issues/245 | 58452925 | MDEyOklzc3VlQ29tbWVudDU4NDUyOTI1 | 514053 | 2014-10-09T01:37:40Z | 2014-10-09T01:37:40Z | CONTRIBUTOR | re: using accessors such as get_variables. To be fair, this pull request didn't really switch the behavior, it was already very similar but with different names (store_variables, open_store_variable) that were now changed to get_variables etc. I chose to continue with getters and setters because it makes it fairly clear what needs to be implemented to make a new DataStore, and allows for some post processing such as _decode_variable_name and encoding/decoding. Its not entirely clear to me how that would fit into a properties based approach so sounds like a good follow up pull request to me. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
44718119 |